[Console] SymfonyStyle: fix block rpadding when escaping '<' #14600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ogizanagi
commented
May 10, 2015
ogizanagi
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | - |
| License | MIT |
| Doc PR | - |
|
The result looks good. Though I don't understand why this is necessary. @ogizanagi Did you find the cause for this issue? |
|
@xabbuh : AFAIU, it's only due to extra backslashes introduced by the |
|
@ogizanagi Indeed, that makes sense. 👍 |
|
👍 |
| @@ -85,7 +85,7 @@ public function block($messages, $type = null, $style = null, $prefix = ' ', $pa | |||
|
|
|||
| foreach ($lines as &$line) { | |||
| $line = sprintf('%s%s', $prefix, $line); | |||
| $line .= str_repeat(' ', $this->lineLength - Helper::strlen($line)); | |||
| $line .= str_repeat(' ', $this->lineLength - Helper::strlen($line) + substr_count($line, '\<')); | |||
There was a problem hiding this comment.
would you mind add a comment above that explain the change :) ?
There was a problem hiding this comment.
Should I link this PR as reference in a comment ? comment + link or just link ?
There was a problem hiding this comment.
https://github.com/symfony/symfony/pull/14600/files#diff-18b76c26b226bea37b2b821a5e4962ffR88
Let me know what comment you expect if you think it's better :)
|
Thank you @ogizanagi. |
nicolas-grekas
added a commit
that referenced
this pull request
May 15, 2015
…<' (ogizanagi) This PR was merged into the 2.7 branch. Discussion ---------- [Console] SymfonyStyle: fix block rpadding when escaping '<' | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | -  Commits ------- 80fc341 [Console] SymfonyStyle: fix block rpadding when escaping '<'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.