[WebProfilerBundle] Fix compatiblity with HttpKernel < 2.7 #14645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
added a commit
to silexphp/Silex-WebProfiler
that referenced
this pull request
May 15, 2015
This PR was merged into the 2.0.x-dev branch. Discussion ---------- Fix Twig & Routing profilers 1. Fix the Twig template definition to show the "Twig" item in the profiler menu. 2. Use the service `request_matcher` which replace `url_matcher` in Silex 2. [Tests are failing](https://travis-ci.org/GromNaN/Silex-WebProfiler/builds/62699523) due to an incompatibility between `symfony/webprofiler-bundle 2.7` and `symfony/http-kernel 2.6`. This issue is resolved by symfony/symfony#14645 | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | no | Fixed tickets | - | License | MIT Commits ------- 182f6eb Split tests for each feature 7f26fdd Fix Routing Profiler to use the request matcher aa7e0a2 Fix twig profiler template
|
Thank you @GromNaN. |
fabpot
added a commit
that referenced
this pull request
May 15, 2015
… (GromNaN) This PR was merged into the 2.7 branch. Discussion ---------- [WebProfilerBundle] Fix compatiblity with HttpKernel < 2.7 The WebProfilerBundle version 2.7 is supposed to be compatible with HttpKernel 2.4, but the template of the config profile uses a property `symfonyState` that has been added in Symfony 2.7 by #13626. > Twig_Error_Runtime: Method "symfonyState" for object "Symfony\Component\HttpKernel\DataCollector\ConfigDataCollector" does not exist in "@WebProfiler/Collector/config.html.twig" at line 12 This fix makes the property optional. | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | silexphp/Silex-WebProfiler#63 | License | MIT Commits ------- 700fcf1 Fix WebProfilerBundle compatiblity with HttpKernel < 2.7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The WebProfilerBundle version 2.7 is supposed to be compatible with HttpKernel 2.4, but the template of the config profile uses a property
symfonyStatethat has been added in Symfony 2.7 by #13626.This fix makes the property optional.