[ServerBag] Handled bearer authorization header in REDIRECT_ form #13633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apache rewrite module renames client request header (`HTTP_`) by prepending `REDIRECT_` to it. http basic authentication and http digest authentication are properly processed in REDIRECT_ form, while bearer is processed in HTTP_ form, but dropped in REDIRECT_ form.
|
ping @symfony/deciders |
|
👍 Looks like a good idea to me. |
|
Thank you @Lance0312. |
fabpot
added a commit
that referenced
this pull request
May 16, 2015
…T_ form (Lance0312) This PR was merged into the 2.3 branch. Discussion ---------- [ServerBag] Handled bearer authorization header in REDIRECT_ form | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Apache rewrite module renames client request header (`HTTP_`) by prepending `REDIRECT_` to it. http basic authentication and http digest authentication are properly processed in REDIRECT_ form, while bearer is processed in HTTP_ form, but dropped in REDIRECT_ form. Example: The following auth headers are handled in ServerBag, ``` HTTP_AUTHORIZATION => Basic aGVsbG86d29ybGQ= REDIREDCT_HTTP_AUTHOIZATION => Basic aGVsbG86d29ybGQ= HTTP_AUTHORIZATION => Digest blah REDIRECT_HTTP_AUTHORIZATION => Digest blah HTTP_AUTHORIZATION => Bearer mF_9.B5f-4.1JqM ``` while ``` REDIRECT_HTTP_AUTHORIZATION => Bearer mF_9.B5f-4.1JqM ``` is dropped. Commits ------- 7b2e2df Handled bearer authorization header in REDIRECT_ form
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apache rewrite module renames client request
header (
HTTP_) by prependingREDIRECT_toit. http basic authentication and http digest
authentication are properly processed in
REDIRECT_ form, while bearer is processed in
HTTP_ form, but dropped in REDIRECT_ form.
Example:
The following auth headers are handled in ServerBag,
while
is dropped.