[HttpKernel] Handle an array vary header in the http cache store #14635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jakzal
commented
May 14, 2015
jakzal
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #12118 |
| License | MIT |
| Doc PR | - |
| @@ -127,7 +127,7 @@ public function lookup(Request $request) | |||
| // find a cached entry that matches the request. | |||
| $match = null; | |||
| foreach ($entries as $entry) { | |||
| if ($this->requestsMatch(isset($entry[1]['vary'][0]) ? $entry[1]['vary'][0] : '', $request->headers->all(), $entry[0])) { | |||
| if ($this->requestsMatch(isset($entry[1]['vary'][0]) ? implode(', ', $entry[1]['vary']) : '', $request->headers->all(), $entry[0])) { | |||
There was a problem hiding this comment.
There's one more place in this class where only the first vary header is used. It doesn't seem to be an issue in there though. At least I failed to introduce a failing test justifying a change (so far).
jakzal
force-pushed
the
bugfix/http-kernel-12118-vary-headers-passed-as-array
branch
from
e2a5a4e
to
5930800
Compare
|
👍 |
fabpot
changed the title
|
Thank you @jakzal. |
fabpot
added a commit
that referenced
this pull request
May 21, 2015
… store (jakzal) This PR was merged into the 2.3 branch. Discussion ---------- [HttpKernel] Handle an array vary header in the http cache store | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #12118 | License | MIT | Doc PR | - Commits ------- 5930800 [HttpKernel] Handle an array vary header in the http cache store
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.