Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Serializer] AbstractNormalizer::instantiateObject allow default values when not optional #14745

Merged
merged 1 commit into from May 25, 2015

Conversation

boekkooi
Copy link
Contributor

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

This PR fixes a bug in the AbstractNormalizer when denormalizing a array with a missing value but a default value set in the class constructor.

@dunglas
Copy link
Member

dunglas commented May 25, 2015

👍
Btw, can you fix fabbot errors?

@dunglas dunglas added the Ready label May 25, 2015
@boekkooi
Copy link
Contributor Author

@dunglas Do i have to? since it's already fixed by #14711

@dunglas
Copy link
Member

dunglas commented May 25, 2015

So it's fine :)

@fabpot
Copy link
Member

fabpot commented May 25, 2015

Thank you @boekkooi.

@fabpot fabpot merged commit 266d53e into symfony:2.7 May 25, 2015
fabpot added a commit that referenced this pull request May 25, 2015
…efault values when not optional (boekkooi)

This PR was merged into the 2.7 branch.

Discussion
----------

[Serializer] AbstractNormalizer::instantiateObject allow default values when not optional

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

This PR fixes a bug in the AbstractNormalizer when denormalizing a array with a missing value but a default value set in the class constructor.

Commits
-------

266d53e [Serializer] AbstractNormalizer::instantiateObject allow default values when not optional
@boekkooi
Copy link
Contributor Author

Thanks @dunglas and @fabpot for the quick responses!

@boekkooi boekkooi deleted the serializer-issue-2 branch May 25, 2015 07:49
sandergo90 pushed a commit to sandergo90/symfony that referenced this pull request Jul 4, 2019
…allow default values when not optional (boekkooi)

This PR was merged into the 2.7 branch.

Discussion
----------

[Serializer] AbstractNormalizer::instantiateObject allow default values when not optional

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

This PR fixes a bug in the AbstractNormalizer when denormalizing a array with a missing value but a default value set in the class constructor.

Commits
-------

266d53e [Serializer] AbstractNormalizer::instantiateObject allow default values when not optional
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants