Skip to content
This repository has been archived by the owner on Apr 13, 2022. It is now read-only.

fix(ngModel): allow setting model to NaN when asyncValidator is present #11411

Closed
wants to merge 1 commit into from

Conversation

Narretz
Copy link
Contributor

@Narretz Narretz commented Mar 24, 2015

Fixes #11315

scope.$apply(function() {
scope.value = NaN;
});
}).not.toThrowMinErr('$rootScope', 'infdig', '10 $digest() iterations reached. Aborting!\n' +
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer a plain not.toThrow(), because this test might become useless if the minErr changes.

@Narretz Narretz closed this in 948120e Apr 3, 2015
netman92 pushed a commit to netman92/angular.js that referenced this pull request Aug 8, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting model to NaN causes infdig if $asyncValidators is used
4 participants