Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

ngAria : aria-checked attribute for components with role=checkbox #11317

Closed
RaphStein opened this issue Mar 13, 2015 · 2 comments
Closed

ngAria : aria-checked attribute for components with role=checkbox #11317

RaphStein opened this issue Mar 13, 2015 · 2 comments
Assignees
@Narretz
Labels
component: forms component: ngAria severity: regression type: bug
Milestone
1.4.0-beta.7 / 1....

Comments

@RaphStein
Copy link
Contributor

Hello,
It seem's that the last version of ngAria (1.3.14 and 1.4.0beta5 ) has a regression for components with role=checkbox.
Even if the component is not checked the value of aria-check is always set to true.
I used the plunker from the Angular Accessibility Developper guide to test it.
In the plunker when I set the version of ngAria to 1.4.0beta4 it works.
@Narretz
Copy link
Contributor

Narretz commented Mar 13, 2015

Okay, I'm pretty sure I broke this when I fixed some edge cases for normal checkboxes and radios.

@Narretz Narretz added this to the 1.4.0-beta.6 / 1.3.15 milestone Mar 13, 2015
@Narretz Narretz self-assigned this Mar 13, 2015
@RaphStein
Copy link
Contributor Author

Hi, component with role=menuitemcheckbox has also the same regression (Even if the component is not checked the value of aria-check is always set to true).

Narretz added a commit to Narretz/angular.js that referenced this issue Mar 16, 2015
@Narretz
fix(ngAria): handle elements with role="checkbox/menuitemcheckbox"
60f0923 
Fixes angular#11317
Closes angular#11321
Narretz added a commit that referenced this issue Mar 17, 2015
@Narretz @petebacondarwin
fix(ngAria): handle elements with role="checkbox/menuitemcheckbox"
1c282af 
Fixes #11317
Closes #11321
netman92 pushed a commit to netman92/angular.js that referenced this issue Aug 8, 2015
@Narretz @netman92
fix(ngAria): handle elements with role="checkbox/menuitemcheckbox"
d1ef6a6 
Fixes angular#11317
Closes angular#11321
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Narretz Narretz

Labels
component: forms component: ngAria severity: regression type: bug
Projects
None yet
Milestone
1.4.0-beta.7 / 1.3.16
Development

No branches or pull requests
3 participants
@petebacondarwin @Narretz @RaphStein