Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

different behavior angular-animate.js angular-animate.min.js (1.2.26) in Firefox 33.0.2 #9936

Closed
pepperblue opened this issue Nov 6, 2014 · 5 comments
Closed

different behavior angular-animate.js angular-animate.min.js (1.2.26) in Firefox 33.0.2 #9936

pepperblue opened this issue Nov 6, 2014 · 5 comments
Assignees
@matsko
Labels
component: ngAnimate severity: broken expected use severity: confusing
Milestone
Backlog - won't fix

Comments

@pepperblue
Copy link

I use SolydK 64bit with latest Firefox (33.0.2). The following code behaves different when using minified version of angular-animate:

----------- html ------------------

<!DOCTYPE html>
<html lang="de" xmlns="http://www.w3.org/1999/html">
<head>
    <meta charset="UTF-8">
    <title>AnimateTest</title>
    <script src="//ajax.googleapis.com/ajax/libs/angularjs/1.2.26/angular.min.js"></script>
    <script src="//ajax.googleapis.com/ajax/libs/angularjs/1.2.26/angular-animate.js"></script>
    <link href="main.css" rel="stylesheet" type="text/css">
</head>
<body data-ng-app="ngAnimate">
    <div class="animate-show" data-ng-hide="showPartial">
        Some content here ...
    </div>
    <input type="checkbox" data-ng-model="showPartial">Click here ...
</body>
</html>

----------- css --------------------

.animate-show {
    -webkit-transition:all linear 0.5s;
    transition:all linear 0.5s;
    line-height:20px;
    opacity:1;
    padding:10px;
    border:1px solid black;
    background:white;
}

.animate-show.ng-hide {
    line-height:0;
    opacity:0;
    padding:0 10px;
}

.check-element {
    padding:10px;
    border:1px solid black;
    background:white;
}

Using the unminified version of angular-animate everything works fine. Using the minified version hiding the <div> is animated but showing is not (it just pops out). In Chromium everything works as expected so it could be a Firefox-Bug, but with Angular Version 1.3.1 things are working in Firefox too ... so it should be an issue you can solve in the 'stable' branch by yourself ...
@pepperblue pepperblue changed the title different behavior angular-animte.js angular-animate.min.js (1.2.26) in Firefox 33.0.2 different behavior angular-animate.js angular-animate.min.js (1.2.26) in Firefox 33.0.2 Nov 6, 2014
@btford
Copy link
Contributor

btford commented Nov 7, 2014

Please put your reproduction in jsbin, plnkr.co, or jsfiddle. This saves us a lot of time. Thanks!

@pepperblue
Copy link
Author

Saved in jsfiddle:
http://jsfiddle.net/wL4uuho7/

@caitp
Copy link
Contributor

caitp commented Nov 10, 2014

can reproduce in Chrome too, not just FF. (or rather, the Chrome behaviour looks broken in more or less the same was as FF36 --- however FF36 is not broken in the same way as described).

@caitp caitp added this to the Backlog milestone Nov 10, 2014
@lgalfaso lgalfaso mentioned this issue Nov 20, 2014
Closed
matsko added a commit to matsko/angular.js that referenced this issue Mar 31, 2015
@matsko
fix(ngAnimate): ensure that minified repaint code isn't removed
14484c1 
Closes angular#9936
@matsko matsko mentioned this issue Mar 31, 2015
Closed
@matsko
Copy link
Contributor

matsko commented Mar 31, 2015

Good things come from patience and hard work: #11469

matsko added a commit to matsko/angular.js that referenced this issue Mar 31, 2015
@matsko
fix(ngAnimate): ensure that minified repaint code isn't removed
b354dc5 
Closes angular#9936
matsko added a commit to matsko/angular.js that referenced this issue Mar 31, 2015
@matsko
fix(ngAnimate): ensure that minified repaint code isn't removed
6cc38b8 
Closes angular#9936
matsko added a commit to matsko/angular.js that referenced this issue Mar 31, 2015
@matsko
fix(ngAnimate): ensure that minified repaint code isn't removed
7cd1b70 
Closes angular#9936
matsko added a commit that referenced this issue Mar 31, 2015
@matsko
fix(ngAnimate): ensure that minified repaint code isn't removed
b041b66 
Closes #9936
matsko added a commit that referenced this issue Mar 31, 2015
@matsko
fix(ngAnimate): ensure that minified repaint code isn't removed
d5c99ea 
Closes #9936
@matsko matsko closed this as completed in c55a494 Mar 31, 2015
@matsko
Copy link
Contributor

matsko commented Mar 31, 2015

This fix touches 1.2, 1.3 and the 1.4 beta.

netman92 pushed a commit to netman92/angular.js that referenced this issue Aug 8, 2015
@matsko @netman92
fix(ngAnimate): ensure that minified repaint code isn't removed
db12bb6 
Closes angular#9936
ggershoni pushed a commit to ggershoni/angular.js that referenced this issue Sep 29, 2015
@matsko
fix(ngAnimate): ensure that minified repaint code isn't removed
7a807dc 
Closes angular#9936
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@matsko matsko

Labels
component: ngAnimate severity: broken expected use severity: confusing
Projects
None yet
Milestone
Backlog - won't fix
Development

Successfully merging a pull request may close this issue.

fix(ngAnimate): ensure that minified repaint code isn't removed matsko/angular.js
4 participants
@matsko @btford @caitp @pepperblue