This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
fix($cookies): update $cookies to prevent duplicate cookie writes #11515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… play nice with external code Update the ngCookies service to prevent repetitive writes via $browser.cookies() Also it is possible for $cookies to get confused about cookies modified outside of $cookies and see those changes as user changes via the $cookies service which would then be set again. This unnecessary setting of cookies can duplicate or overwrite depending on the original cookie's domain. This update prevents that scenario. Closes angular#11490
| updated = true; | ||
| } | ||
| } | ||
|
|
||
| //verify what was actually stored | ||
| if (updated) { | ||
| updated = false; |
There was a problem hiding this comment.
updated is not evaluated after line 106.
|
looks good to igor |
IgorMinar
pushed a commit
that referenced
this pull request
Jun 5, 2015
… play nice with external code Update the ngCookies service to prevent repetitive writes via $browser.cookies() Also it is possible for $cookies to get confused about cookies modified outside of $cookies and see those changes as user changes via the $cookies service which would then be set again. This unnecessary setting of cookies can duplicate or overwrite depending on the original cookie's domain. This update prevents that scenario. Closes #11490 Closes #11515
|
landed as 706a93a thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update $cookies to prevent duplicate cookie writes and play nice with external code
Update the ngCookies service to prevent repetitive writes via $browser.cookies()
Also it is possible for $cookies to get confused about cookies modified outside of $cookies and
see those changes as user changes via the $cookies service which would then be set again. This
unnecessary setting of cookies can duplicate or overwrite depending on the original cookie's
domain. This update prevents that scenario.
Closes #11490