Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't format raw 'update' statement result #3800

Closed
wants to merge 1 commit into from
Closed

don't format raw 'update' statement result #3800

wants to merge 1 commit into from

Conversation

pkoretic
Copy link
Contributor

this is proposed change from issue #3795
if anything else is needed (tests) please point me in right direction, thanks

@pkoretic
Copy link
Contributor Author

@janmeier
I guess this is mine https://travis-ci.org/sequelize/sequelize/jobs/64005960

  1) [SQLITE] Model update returns the number of affected rows:
     AssertionError: expected undefined to equal 2
      at self.User.update.spread.then.self.User.update.username (test/integration/model.test.js:1085:35)
  From previous event:
      at Promise.spread (lib/promise.js:21:17)
      at test/integration/model.test.js:1084:83
  From previous event:
      at Promise.then (lib/promise.js:21:17)
      at Context.<anonymous> (test/integration/model.test.js:1083:41)

@janmeier
Copy link
Member

Hmm yea it seems the query is not being properly interpreted as a bulk update query. At least somehow the number of affected rows is not being passed back properly ..

@janmeier janmeier closed this in d216783 May 26, 2015
@janmeier
Copy link
Member

@pkoretic The problem was that sqlite actually depended on the old behaviour - fixed now :)

IrfanBaqui pushed a commit to IrfanBaqui/sequelize that referenced this pull request Jun 24, 2015
@janmeier
Fix sequelize#3800 for sqlite
10f2129
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pkoretic @janmeier