Type warnings #3839
Type warnings #3839
Conversation
|
I like this implementation very much! :) LGTM |
|
This will close #2038 |
|
|
||
| // MSSQL does not support any parameters for integer | ||
| if (this._length || this.options.length || this._unsigned || this._zerofill) { | ||
| this.warn('You used INTEGER with a attribute. This is not supported by MSSQL. Simple `INTEGER` will be used instead.'); |
|
Looks great. Warnings are the way to go, since i don't personally thing we should ever remove support completely. |
|
Rebased, fixed a couple typos and included more warnings. Depending on what you wish I'd say it's ready to merge. We could provide the additional functionality to include the lines later on. |
|
You're still mixing |
|
General wording might be better with something like 'postgres does not support TEXT with size. Simple 'TEXT' will be used instead` |
|
+1 |
|
Changed the comments and rebased |
|
Please, see #6385 I really don't like this PR, there is a way to disable completely this messages? |
This is on top of #3836 and I wanted to get your feedback what you think about the implementation. So you only have to look at the "Initial commit" changes.
If someone uses a data type in a way that is not supported we'd now warn the user about it including what we do instead and presenting the link to the data types as they are in the current dialect.