Skip to content
This repository has been archived by the owner on Jan 22, 2019. It is now read-only.

Support escapes at beginning of the file #75

Merged
merged 1 commit into from Apr 15, 2015

Conversation

davidnavas
Copy link
Contributor

@wli600
CsvReader doesn't properly unescape characters if the escape character is the first character read.
I've added a test and addressed the issue.

@cowtowncoder
Copy link
Member

Makes sense, will be happy to merge this. Thanks!

One quick thing first: before the first contribution, we need a filled Contributor License Agreement (CLA).
PDF is available from:

https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf

and all that is needed is to print, fill & sign, scan and email to info at fasterxml dot com.
Once this is done, I can merge any and all contributions to Jackson projects. But we need it to ensure all code can be distributed by us, and further re-distributed by users.

If you could do that when you get a chance I can merge this in, backport it in 2.5, and it should make it in 2.5.3 as well as 2.6.0.

@davidnavas
Copy link
Contributor Author

makes sense, will do so shortly. Shouldn't be a problem given the last backport of #54 in this release is my coworker's :)

Should I worry about the build failure? Wasn't sure why my change would affect rake at all.

@cowtowncoder
Copy link
Member

I'll see what gives test failure.

cowtowncoder added a commit that referenced this pull request Apr 15, 2015
Support escapes at beginning of the file
@cowtowncoder cowtowncoder merged commit 7285012 into FasterXML:2.4 Apr 15, 2015
cowtowncoder added a commit that referenced this pull request Apr 15, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants