Fix Infinite recursion (StackOverflowError) when serializing a SOAP object. #766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok looks good to me, will be happy to merge. One practicality we do need however is to get a Contributor License Agreement (CLA) from: https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf It's a simple one-page form, and needs to be filled, signed, scanned and emailed to Thank you once again! |
cowtowncoder
added a commit
that referenced
this pull request
Apr 22, 2015
Fix Infinite recursion (StackOverflowError) when serializing a SOAP object.
|
Also: +1 for doing this against 2.5, less merging for me! Thank you again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to to rearrange slightly the OptionalHandlerFactory#findSerializer logic to use the DOMSerializer when handling a SOAP object to fix an infinite recursion.
Look at TestSOAP for a test case.