Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rabbitmq-script-wrapper: "exec" before "su rabbitmq ..." is useless #129

Closed
dumbbell opened this issue Apr 23, 2015 · 3 comments
Closed
Assignees
Milestone

Comments

@dumbbell
Copy link
Member

In ec851de, I prefixes all commands with exec to stay in the same process (and not fork a new one). This is useless in front of su rabbitmq -c '...' because su(1) forks a process anyway.

This broke RabbitMQ's Docker image, something this commit was supposed to fix... Let's remove exec before su.

This is part of issue #113.

@dumbbell dumbbell self-assigned this Apr 23, 2015
@dumbbell dumbbell added this to the 3.5.2 milestone Apr 23, 2015
dumbbell referenced this issue Apr 30, 2015
Without this, a new process is spawned to execute the script. This new
process won't receive the signals delivered to the process initially
started.

A user reported this problem with RabbitMQ in Docker: when the service
must be stopped, the SIGTERM doesn't make it to the server which
continues to run.
@dumbbell
Copy link
Member Author

dumbbell commented May 6, 2015

@tianon, any opinion on this branch (regarding your comment on @ec851de0)?

@tianon
Copy link
Contributor

tianon commented May 7, 2015

Sorry, 👍; su does strange things.

@dumbbell
Copy link
Member Author

Since RabbitMQ 3.5.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants