Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: 1.0.0-rc5 break tel: link #3647

Closed
henryavila opened this issue Apr 30, 2015 · 5 comments
Closed

bug: 1.0.0-rc5 break tel: link #3647

henryavila opened this issue Apr 30, 2015 · 5 comments

Comments

@henryavila
Copy link

Type: bug

Platform: android 4.4 webview

When I update ionic to RC5 my tel: simply stop to work on mobile (tested on Android).
I checked my config.xml, its ok. roollbak the ionic to RC4 and it back to work. Updated again to RC5 and it stop to work again. For some reason this update just broke the tel: links.

My code is this

<a class="button button-assertive" ng-if="item.phone" ng-href="tel:{{item.phone}}">
<i class="icon ion-ios-telephone-outline light"></i>
</a>

I'm using it for about four months without any problem. The problem came just when I updated the lib
@henryavila henryavila changed the title RC5 break tel: link bug: RC5 break tel: link Apr 30, 2015
@henryavila henryavila changed the title bug: RC5 break tel: link bug: 1.0.0-rc5 break tel: link Apr 30, 2015
@jeanmatthieud
Copy link

I saw it too.

@joshbuchea
Copy link

Incase it's helpful for anyone, in an Ionic project with RC5 that I'm currently working on I use a function to call the tel link and that still works.

document.location.href = 'tel:' + phone;

@jeanmatthieud
Copy link

It would be great to add "geo:" links and all supported links with the new "cordova-plugin-whitelist"

@olach
Copy link

olach commented May 13, 2015

Thanks for this fix. But do you really need to also add "tel:" to imgSrcSanitizationWhitelist? "Tel:" is only used on links, not images. :)

@henryavila
Copy link
Author

Angular make images linkable too. It can be uses on images

Em qua, 13 de mai de 2015 05:42, Ola Christensson notifications@github.com
escreveu:

Thanks for this fix. But do you really need to also add "tel:" to
imgSrcSanitizationWhitelist? "Tel:" is only used on links, not images. :)

—
Reply to this email directly or view it on GitHub
#3647 (comment).

@jeanmatthieud jeanmatthieud mentioned this issue Sep 1, 2015
Closed
@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@olach @jeanmatthieud @joshbuchea @henryavila