Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
fix(ionicConfig): allow using tel for hrefs
Closes #3647
  • Loading branch information
mhartington committed May 5, 2015
1 parent 4e74ead commit db730f1
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions js/angular/service/ionicConfig.js
Expand Up @@ -628,6 +628,6 @@ IonicModule
// http://blogs.msdn.com/b/msdn_answers/archive/2015/02/10/
// running-cordova-apps-on-windows-and-windows-phone-8-1-using-ionic-angularjs-and-other-frameworks.aspx
.config(['$compileProvider', function($compileProvider) {
$compileProvider.aHrefSanitizationWhitelist(/^\s*(https?|ftp|mailto|file|ghttps?|ms-appx|x-wmapp0):/);
$compileProvider.imgSrcSanitizationWhitelist(/^\s*(https?|ftp|file|ms-appx|x-wmapp0):|data:image\//);
$compileProvider.aHrefSanitizationWhitelist(/^\s*(https?|tel|ftp|mailto|file|ghttps?|ms-appx|x-wmapp0):/);
$compileProvider.imgSrcSanitizationWhitelist(/^\s*(https?|tel|ftp|file|ms-appx|x-wmapp0):|data:image\//);
}]);

3 comments on commit db730f1

@olach
Copy link

@olach olach commented on db730f1 May 13, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Tel" is not needed on imgSrc. Only on aHref.

@mhartington
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Will fix this

@mhartington
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in our 1.0.1 branch
d256870

Please sign in to comment.