Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Bug - InfiniteScroll broken in native scroll #3682

Closed
melnikov77 opened this issue May 8, 2015 · 1 comment
Closed

bug: Bug - InfiniteScroll broken in native scroll #3682

melnikov77 opened this issue May 8, 2015 · 1 comment

Comments

@melnikov77
Copy link

Type: bug

Platform: all

After updating to rc5 the InfiniteScroll get broken if is used in native scroll.
Here is error:
TypeError: Cannot read property '__container' of undefined
at ionic.bundle.js:47148
at ionic.bundle.js:24859
at completeOutstandingRequest (ionic.bundle.js:13541)
at ionic.bundle.js:13921

The problem is in the commit "fix(infiniteScroll): prevent checkbounds when infinitescroll completes when page is cached. Fixes #2694".

  •  self.checkBounds();
    
  •  // only check bounds again immediately if the page isn't cached (scroll el has height)
    
  •  if (self.scrollView.__container && self.scrollView.__container.offsetHeight > 0) {
    
  •    self.checkBounds();
    
  •  }
    

In native scroll mode the scrollView is undefined.

@melnikov77 melnikov77 changed the title Bug - InfiniteScroll broken in native scroll bug: Bug - InfiniteScroll broken in native scroll May 8, 2015
@perrygovier
Copy link
Contributor

Thanks!

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants