Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gracefully handle SIGEXIT signal in tsr #776

Closed
cezarsa opened this issue Apr 30, 2014 · 5 comments
Closed

Gracefully handle SIGEXIT signal in tsr #776

cezarsa opened this issue Apr 30, 2014 · 5 comments
Assignees
Milestone

Comments

@cezarsa
Copy link
Member

cezarsa commented Apr 30, 2014

SIGEXIT should wait for ongoing requests to end before shutting down the server. Some references of projects that help with this:
https://github.com/braintree/manners
https://github.com/cupcake/mannersagain

@fsouza
Copy link
Contributor

fsouza commented May 14, 2014

We should handle SIGTERM too.

@cezarsa
Copy link
Member Author

cezarsa commented Jun 23, 2014

A better approach to this seem to be https://github.com/stretchr/graceful however it depends on API only available to Go 1.3+ (as described in https://code.google.com/p/go/issues/detail?id=4674)
What do you think about requiring Go 1.3?

@cezarsa
Copy link
Member Author

cezarsa commented Apr 16, 2015

Commit 558f650 address a part of this issue, it handles waiting for requests to finish and not listening for further connections.
However we also need to:

  • Stop healing and wait for current healings to finish;
  • Stop queue processing and wait for current jobs to finish;
  • Stop node auto scaling checks and wait for current scaling processes to finish;
  • Stop log pub/sub connections to close log -f requests

@cezarsa cezarsa self-assigned this Apr 22, 2015
@cezarsa
Copy link
Member Author

cezarsa commented Apr 23, 2015

Finished but forgot to reference issue in commits. :/

@cezarsa cezarsa closed this as completed Apr 23, 2015
@fsouza
Copy link
Contributor

fsouza commented Apr 23, 2015

@tarsisazevedo tarsisazevedo added this to the 0.11.0 milestone May 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants