Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api: deploy detail endpoint fails with deploys by app-deploy #1098

Closed
andrewsmedina opened this issue Feb 5, 2015 · 0 comments
Closed

api: deploy detail endpoint fails with deploys by app-deploy #1098

andrewsmedina opened this issue Feb 5, 2015 · 0 comments
Assignees
@fsouza
Labels
bug
Milestone
0.11.0

Comments

@andrewsmedina
Copy link
Contributor 

GET /deploy/1234
Caught error getting repository metadata: Caught error getting repository metadata: Error when trying to obtain diff between hash commits of repository bla (Hash Commit(s) are required).\n\n

The handler should returns the other data about deploy when a deploy has not diff.
@andrewsmedina andrewsmedina self-assigned this Feb 5, 2015
@andrewsmedina andrewsmedina mentioned this issue Feb 5, 2015
Closed
@andrewsmedina andrewsmedina added this to the 0.11.0 milestone Mar 6, 2015
@fsouza fsouza assigned fsouza and unassigned andrewsmedina Mar 10, 2015
fsouza pushed a commit that referenced this issue Mar 10, 2015
api, app: use the Deploy type for marshalling deploy info
c6140b9 
I will check if this breaks the client, but hopefully no.

Related to #1098.
@fsouza fsouza closed this as completed in ae85e25 Mar 10, 2015
fsouza added a commit to tsuru/tsuru-dashboard that referenced this issue Mar 10, 2015
@fsouza
views/deploy_info: fix the view for absent diff
16c337e 
Related to tsuru/tsuru#1098.
fsouza pushed a commit that referenced this issue Mar 10, 2015
docs/reference/api: update the example for deploy info endpoint
a33c55a 
Related to #1098.
fsouza added a commit to tsuru/tsuru-dashboard that referenced this issue Mar 10, 2015
@fsouza
admin/views: fix deploy info view
3493cf2 
Related to tsuru/tsuru#1098.
fsouza pushed a commit that referenced this issue Mar 10, 2015
api/deploy: fix diff rendering
bfec40c 
Related to #1098.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fsouza fsouza

Labels
bug
Projects
None yet
Milestone
0.11.0
Development

No branches or pull requests
2 participants
@andrewsmedina @fsouza