Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug when setting a select value to emty (null or "") while changing number of attrs #569

Closed
ldimi opened this issue Apr 17, 2015 · 1 comment
Closed

bug when setting a select value to emty (null or "") while changing number of attrs #569

ldimi opened this issue Apr 17, 2015 · 1 comment
Labels
Type: Bug For bugs and any other unexpected breakage

Comments

@ldimi
Copy link

ldimi commented Apr 17, 2015

When changing the number of attributes on a select node, the node gets recreated.
But when you set the value to empty at te same time, this is'nt enforced on the select node, resulting in an inconsistent ui.

I made a fiddle to illustrate the problem : https://jsfiddle.net/cnrdz0n9/3/
(Just toggle a few times between "two" and empty)

(this worked until version 0.1.22)
ldimi pushed a commit to ldimi/mithril.js that referenced this issue Apr 17, 2015
bugfix issue MithrilJS#569 : also set empty value (null or "") on sel…
23514e9 
…ect node
lhorie added a commit that referenced this issue Apr 18, 2015
@lhorie
#569 fix diff edge case w/ select input
6c32afe
@lhorie lhorie added the Type: Bug For bugs and any other unexpected breakage label Apr 18, 2015
@lhorie
Copy link
Member

lhorie commented Apr 18, 2015

Fixed in components branch

@lhorie lhorie closed this as completed Apr 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug For bugs and any other unexpected breakage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ldimi @lhorie