Fix _field_names to be disabled on pre 1.3.0 indexes
#10268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjernst
added
>bug
v2.0.0-beta1
:Search/Mapping
|
looks good |
rjernst
force-pushed
the
fix/field-names-bwc
branch
from
e87f49c
to
467d229
Compare
In elastic#9893, an enabled flag was added for _field_names. However, backcompat for indexes created before 1.3.0 (when _field_names was added) was lost. This change corrects the mapper to always be disabled when used with older indexes that cannot have _field_names. closes elastic#10268
rjernst
force-pushed
the
fix/field-names-bwc
branch
from
467d229
to
ae41d1e
Compare
rjernst
added a commit
that referenced
this pull request
Mar 25, 2015
This is a follow up to #10268.
rjernst
added a commit
that referenced
this pull request
Mar 25, 2015
This is a follow up to #10268.
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Apr 27, 2015
The _field_names field was fixed in 1.5.1 (elastic#10268) to correctly be disabled for indexes before 1.3.0. However, only the exists filter was updated to check this enabled flag on 1.x/1.5. The missing filter on those branches still checks the field type to see if it is indexed, which causes the filter to always try and use the _field_names field for those old indexes. This change adds a test to the old index tests for missing filter. Note: Something alarming about this test is it does not always fail. If I narrow down to run just on say 1.1.0, it fails most of the time, but not always. @jpountz Maybe you have an idea on why this might be?
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Apr 28, 2015
The _field_names field was fixed in 1.5.1 (elastic#10268) to correctly be disabled for indexes before 1.3.0. However, only the exists filter was updated to check this enabled flag on 1.x/1.5. The missing filter on those branches still checks the field type to see if it is indexed, which causes the filter to always try and use the _field_names field for those old indexes. This change adds a test to the old index tests for missing filter.
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Apr 28, 2015
The _field_names field was fixed in 1.5.1 (elastic#10268) to correctly be disabled for indexes before 1.3.0. However, only the exists filter was updated to check this enabled flag on 1.x/1.5. The missing filter on those branches still checks the field type to see if it is indexed, which causes the filter to always try and use the _field_names field for those old indexes. This change adds a test to the old index tests for missing filter. closes elastic#10842
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Apr 28, 2015
The _field_names field was fixed in 1.5.1 (elastic#10268) to correctly be disabled for indexes before 1.3.0. However, only the exists filter was updated to check this enabled flag on 1.x/1.5. The missing filter on those branches still checks the field type to see if it is indexed, which causes the filter to always try and use the _field_names field for those old indexes. This change adds a test to the old index tests for missing filter. closes elastic#10842
rjernst
added a commit
that referenced
this pull request
Apr 28, 2015
The _field_names field was fixed in 1.5.1 (#10268) to correctly be disabled for indexes before 1.3.0. However, only the exists filter was updated to check this enabled flag on 1.x/1.5. The missing filter on those branches still checks the field type to see if it is indexed, which causes the filter to always try and use the _field_names field for those old indexes. This change adds a test to the old index tests for missing filter. closes #10842
rjernst
added a commit
that referenced
this pull request
Apr 28, 2015
The _field_names field was fixed in 1.5.1 (#10268) to correctly be disabled for indexes before 1.3.0. However, only the exists filter was updated to check this enabled flag on 1.x/1.5. The missing filter on those branches still checks the field type to see if it is indexed, which causes the filter to always try and use the _field_names field for those old indexes. This change adds a test to the old index tests for missing filter. closes #10842
clintongormley
changed the title
_field_names to be disabled on pre 1.3.0 indexes
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
In elastic#9893, an enabled flag was added for _field_names. However, backcompat for indexes created before 1.3.0 (when _field_names was added) was lost. This change corrects the mapper to always be disabled when used with older indexes that cannot have _field_names. closes elastic#10268
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
This is a follow up to elastic#10268.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #9893, an enabled flag was added for _field_names. However,
backcompat for indexes created before 1.3.0 (when _field_names
was added) was lost. This change corrects the mapper
to always be disabled when used with older indexes that
cannot have _field_names.