Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document JS test suite basics #15999

Merged
merged 1 commit into from Mar 7, 2015
Merged

Document JS test suite basics #15999

merged 1 commit into from Mar 7, 2015

Conversation

cvrebert
Copy link
Collaborator

@cvrebert cvrebert commented Mar 5, 2015

This is just a tweaked version of #15952.
Fixes #15951.
CC: @hnrch02 for final review

@cvrebert cvrebert added this to the v3.3.4 milestone Mar 5, 2015
@cvrebert cvrebert mentioned this pull request Mar 5, 2015
Closed
@cvrebert cvrebert force-pushed the kkirsche-includeTestsReadme branch from 812d654 to 644c58e Compare March 5, 2015 06:54
hnrch02
hnrch02 reviewed Mar 5, 2015
View reviewed changes
js/tests/README.md

// Make assertion
assert.strictEqual($alert.hasClass('in'), false, 'remove .in class on .close click')
})
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe an async example could also be of value?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added async example

@cvrebert cvrebert force-pushed the kkirsche-includeTestsReadme branch 2 times, most recently from 1dd82a8 to 71e8aea Compare March 5, 2015 12:15
@kkirsche
Copy link
Contributor

kkirsche commented Mar 5, 2015

Thanks @cvrebert 😃 I'm sure there were plenty of small little things that needed tweaking. Thank you for your time and assistance though on getting this in 👍

@cvrebert
[Fixes #15951] Document JS test suite basics
ba2f7e9 
X-Ref: #15953
Closes #15952 by merging a tweaked version of it.
[skip sauce]
[skip validator]
@cvrebert cvrebert force-pushed the kkirsche-includeTestsReadme branch from 71e8aea to ba2f7e9 Compare March 7, 2015 07:27
cvrebert added a commit that referenced this pull request Mar 7, 2015
@cvrebert
Merge pull request #15999 from twbs/kkirsche-includeTestsReadme
64ca888 
Document JS test suite basics
@cvrebert cvrebert merged commit 64ca888 into master Mar 7, 2015
@cvrebert cvrebert mentioned this pull request Mar 7, 2015
Closed
@cvrebert cvrebert deleted the kkirsche-includeTestsReadme branch March 7, 2015 07:29
@cvrebert
Copy link
Collaborator Author

cvrebert commented Mar 7, 2015

@kkirsche Thanks again

@kkirsche
Copy link
Contributor

kkirsche commented Mar 7, 2015

My pleasure. I'm glad I was able to help with it 😃 I appreciate everyone's patience as it was fixed and finalized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
docs meta
Projects
None yet
Milestone
v3.3.4
Development

Successfully merging this pull request may close these issues.

Document JS test suite basics
3 participants
@cvrebert @kkirsche @hnrch02