[Fixes #15106] Document how to properly handle modals with dynamic height #15910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c content height Fixes twbs#15106 — Document how to properly handle modals with dynamic content height X-Ref: twbs#15881
|
Works for me. |
|
See my comment here for clarification: #15881 (comment) |
|
But documenting it is a good idea, just need to change the text to reflect the new behavior. |
| @@ -394,6 +394,9 @@ <h4 class="modal-title" id="exampleModalLabel">New message</h4> | |||
| }) | |||
| {% endhighlight %} | |||
|
|
|||
| <h2 id="modals-handle-update">Modals with dynamic heights</h2> | |||
| <p>Modals which have a dynamic height such as modals loading their content with AJAX should call <code>$('#myModal').data('bs.modal').handleUpdate()</code> when the content updates to ensure the modal and backdrop are the correct sizes. This only needs to occur if the modal is visible when the update to the modal's content occurs.</p> | |||
There was a problem hiding this comment.
The second sentence repeats "occur", BTW.
Update verbiage per @hnrch02's comment
|
Updated verbiage based on @hnrch02's comments. EDIT: If all good will rebase this. I left it so the history was still here should anyone want to compare |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15106 — Document how to properly handle modals with dynamic content height
X-Ref: #15881 — Fix backdrop not readjusting when height changes