Add source code documentation of justified navbar for #15906 #15916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Document in the source code that the justified nav is meant for single line list items only. This should help prevent Issues like twbs#15906 in the future.
kkirsche
changed the title
|
|
|
👍 no worries. This is certainly an odd situation that has been hard to follow and discuss due to how similar it is to other components. 😃 |
mdo
added a commit
that referenced
this pull request
Feb 25, 2015
Add source code documentation of justified navbar for #15906
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document in the source code that the justified nav is meant for single line list items only. This should help prevent Issues like #15906 in the future.
cc: @cvrebert / @mdo