Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix Issue #15701] [Docs] Tooltip/popover destroy docs and delegation #15742

Merged
merged 1 commit into from Feb 3, 2015

Conversation

kkirsche
Copy link
Contributor

@kkirsche kkirsche commented Feb 3, 2015

[Fix Issue #15701] Tooltip/popover destroy docs don't explain the delegation case.

@kkirsche kkirsche changed the title [Fix Issue #15701] Tooltip/popover destroy docs don't explain the delega... [Fix Issue #15701] Tooltip/popover destroy docs and delegation Feb 3, 2015
@kkirsche kkirsche changed the title [Fix Issue #15701] Tooltip/popover destroy docs and delegation [Fix Issue #15701] [Docs] Tooltip/popover destroy docs and delegation Feb 3, 2015
@cvrebert cvrebert added the docs label Feb 3, 2015
@cvrebert
Copy link
Collaborator

cvrebert commented Feb 3, 2015

Please add an analogous note the the Popover docs too.

@cvrebert cvrebert added this to the v3.3.4 milestone Feb 3, 2015
@kkirsche
Copy link
Contributor Author

kkirsche commented Feb 3, 2015

Oops. Sorry about that. Adding it now 👍

… delegation case

[Fix Issue twbs#15701] Tooltip/popover destroy docs don't explain the delegation case.

Add to popovers
@kkirsche
Copy link
Contributor Author

kkirsche commented Feb 3, 2015

Added and squashed/rebased.

cvrebert added a commit that referenced this pull request Feb 3, 2015
[Fix Issue #15701] [Docs] Tooltip/popover destroy docs and delegation
@cvrebert cvrebert merged commit 0e40c81 into twbs:master Feb 3, 2015
@cvrebert
Copy link
Collaborator

cvrebert commented Feb 3, 2015

For future reference, we prefer commit messages that follow GitHub's format for auto-closing relevant issues: https://help.github.com/articles/closing-issues-via-commit-messages
("Fix Issue #15701" doesn't quite match)

@kkirsche
Copy link
Contributor Author

kkirsche commented Feb 3, 2015

E.g. "Fixes #15701" instead? Sorry, wasn't aware about that, I'll make sure to be more careful about that in the future.

@cvrebert
Copy link
Collaborator

cvrebert commented Feb 3, 2015

Yup, like that. No worries.

@kkirsche
Copy link
Contributor Author

Should this be on v3.3.4 ship list #15624

@cvrebert cvrebert mentioned this pull request Feb 10, 2015
@kkirsche kkirsche deleted the patch-13 branch February 19, 2015 23:58
@mdo
Copy link
Member

mdo commented Mar 1, 2015

Should this have left the Hides and destroys an element's tooltip. snippet (and the popover one)? The comment that appears there now replaced it and makes less sense to me.

kkirsche pushed a commit to kkirsche/bootstrap that referenced this pull request Mar 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants