[Fix Issue #15712] Add example of how to use grid system within a modal #15725
Conversation
|
Sorry about the other pull request (#15724). For whatever reason my forked master branch seems to have something left over from 2.3.2. Until all of my open PR's are merged or closed, I'm not sure how to fix that so I do have to initiate the branch from Github's page. The only idea I have to "fix" it is to delete the forked repo and re-fork it so that it's current. |
| </div> | ||
| <div class="modal-body"> | ||
| <div class="container-fluid"> | ||
| ... |
There was a problem hiding this comment.
Show a couple rows with a couple columns in them so the example is more complete and unambiguous.
|
I can certainly add that, would you like it to show a static modal similar to http://getbootstrap.com/javascript/#modals-examples or is just the code OK? I plan on adding a few rows of code from the grid offsetting section here which should show a more complete view of what is meant. Thoughts? |
|
There should probably be a live non-static example. |
|
Hey @cvrebert that's been added, you may want to look at the tests for dc224d2 though, it failed for no reason related to my code but rather due to an issue with the box. Specifically it fails because it failed to install everything it needed to run it's tests. Excerpt: |
|
FYI, you don't need to make a dummy commit in the future. The Core Team can force Travis to retry pull request builds. |
|
Ah ok, I wasn't sure. Sorry about that. |
|
Just wanted to follow up on this and see if anything was missing. I can rebase it if that's preferred also |
… modal [Fix Issue twbs#15712] Add example of how to use grid system within a modal Show multiple rows with different column patterns Show multiple rows with different column patterns per @cvrebert's suggestion Add live example for the modal Rerun tests
|
Rebased this down to a single commit. Wanted to follow up about this and just check if anything else was necessary. Thanks for your time guys 👍 |
|
It feels unnecessary to add, but I get it. Perhaps, in addition to this, we clarify our grid docs (probably in v4) to reiterate the use of fluid containers and what not. |
|
Anything I can do to help you with that? |
|
Can someone please tell why when using the grid inside a modal it's mentioned to place it inside a .container-fluid? Shouldn't it work without it or are there some issues without it? |
|
@julzmon The container provides necessary padding on the edges of rows to account for the negative margin/padding of grid columns. |
[Fix Issue #15712] Add example of how to use grid system within a modal