Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix Issue #15683] readonly input should not have a not-allowed cursor #15703

Merged
merged 1 commit into from Feb 17, 2015

Conversation

kkirsche
Copy link
Contributor

[Fix Issue #15683] readonly input should not have a not-allowed cursor. Instead, this pull request displays a standard cursor and only displays the not-allowed cursor on disabled items.

@cvrebert cvrebert added the css label Jan 29, 2015
@cvrebert
Copy link
Collaborator

👍 from me

@mdo mdo added this to the v3.3.4 milestone Jan 30, 2015
@mdo
Copy link
Member

mdo commented Jan 30, 2015

:shipit:

@mdo
Copy link
Member

mdo commented Jan 30, 2015

One quick thought though—let's check the docs to see if there's anything we need to update language-wise for referring to the cursors of readonly and disabled inputs.

@kkirsche
Copy link
Contributor Author

I can modify the text on disabled state (which currently is, "Add the disabled boolean attribute on an input to prevent user input and trigger slightly different looks") to include that it changes the cursor as well. E.g. "Add the disabled boolean attribute on an input to prevent user input and trigger slightly a muted color scheme with a not-allowed cursor"

Minor changes to the readonly section may be necessary. Currently, it is "Add the readonly boolean attribute on an input to prevent user input and style the input as disabled" but I would propose "Add the readonly boolean attribute on an input to prevent user input and style the input field as disabled while retaining the standard cursor"

Thoughts?

@mdo
Copy link
Member

mdo commented Jan 30, 2015

@kkirsche Yeah, I can dig that, and that sounds like it'd address both changes clearly enough. I'd suggest going with the following copy though:

Add the disabled boolean attribute on an input to prevent user interactions. Disabled inputs appear lighter and add a not-allowed cursor.

Add the readonly boolean attribute on an input to prevent modification of the input's value. Read-only inputs appear lighter (just like disabled inputs), but retain the standard cursor.

Is that too wordy, @kkirsche and @cvrebert?

@kkirsche
Copy link
Contributor Author

No, I think that works well. If @cvrebert agrees I'll make those changes 👍 Thanks for the feedback

@cvrebert
Copy link
Collaborator

SGTM.

@kkirsche
Copy link
Contributor Author

Updated. Thank you both for the feedback. I took the liberty of linking the disabled input text on the readonly to that section, hope you don't mind. If you do, I can take that out though, I just thought it might be helpful to easily get there if you wanted to see the difference. 👍

… cursor

[Fix Issue twbs#15683] `readonly` input should not have a `not-allowed` cursor. Instead, this pull request displays a standard cursor and only displays the not-allowed cursor on disabled items.

Revise docs wording to clarify cursor display
@kkirsche
Copy link
Contributor Author

kkirsche commented Feb 3, 2015

Squashed commits into single due to small size of this change and it seems to have stabilized in regards to feedback.

@kkirsche
Copy link
Contributor Author

Just wanted to follow up on this and see if anything was missing.

mdo added a commit that referenced this pull request Feb 17, 2015
[Fix Issue #15683] `readonly` input should not have a not-allowed cursor
@mdo mdo merged commit a7a6e7f into twbs:master Feb 17, 2015
@cvrebert cvrebert mentioned this pull request Feb 17, 2015
@kkirsche kkirsche deleted the patch-9 branch February 17, 2015 19:35
@kkirsche
Copy link
Contributor Author

Thanks guys!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants