Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #15597 — Mention dropup variation in dropdown docs #15662

Merged
merged 4 commits into from Feb 19, 2015

Conversation

kkirsche
Copy link
Contributor

Fixes #15597. Mention dropup variation in dropdown docs

Other pull request (#15659) was so messed up I sincerely have no clue how to save it. The recommended command doesn't work, can't believe rebasing is so problematic...

Fix issue twbs#15597 — Mention dropup variation in dropdown docs

Other pull request was so messed up I sincerely have no clue how to save it. The recommended command doesn't work, can't believe rebasing is so problematic...
@cvrebert cvrebert added the docs label Jan 24, 2015
@cvrebert cvrebert added this to the v3.3.4 milestone Jan 24, 2015
@cvrebert
Copy link
Collaborator

CC: @mdo

@vsn4ik
Copy link
Contributor

vsn4ik commented Jan 27, 2015

  • Remove <h3>Example</h3>;
  • Move data-example-id="" to <h3>Dropup Variation</h3> and change value;
  • It is necessary to keep the style of .dropdown examples (position: static), but I do not know how to do it.

@kkirsche
Copy link
Contributor Author

I'm not sure I follow you @vsn4ik on point 3

* Remove `<h3>Example</h3>;`
* Move `data-example-id=""` to `<h3>Dropup Variation</h3>` and change value;
@vsn4ik
Copy link
Contributor

vsn4ik commented Jan 27, 2015

My mistake on point 2: data-example-id not need be moved. Only change, because data-example-id="static-dropdown" already exists.

  • Remove whitespace after h3.
  • Variation not need capitalize.

data-example-id not need be moved. Only change, because data-example-id="static-dropdown" already exists.

Remove whitespace after h3.
Variation not need capitalize.
<h3 id="dropdowns-dropup">Dropup variation</h3>
<p>Trigger dropdown menus above elements by adding <code>.dropup</code> to the parent.</p>
<div class="bs-example" data-example-id="static-dropup">
<div class="dropup clearfix">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did I add the clearfix at some point, or is that new to this PR?

@mdo
Copy link
Member

mdo commented Feb 9, 2015

My only concern with this is that it's basically an exact dupe of another docs section.

@kkirsche
Copy link
Contributor Author

kkirsche commented Feb 9, 2015

I didn't add one to this. I copied and pasted to use what you had.

I had started with a small note only, what would you be interested in as a solution?

@mdo
Copy link
Member

mdo commented Feb 9, 2015

Yeah, I think so @kkirsche.

@kkirsche
Copy link
Contributor Author

kkirsche commented Feb 9, 2015

@mdo What do you think about the following idea:

In the example section we add the following sentence:

Dropdown menus can also be triggered above elements by adding <code>.dropup</code> to the parent.

Then in the example section include one of each. This way, we reduce the space necessary by not including a standalone example for just the dropup variation.

The other idea I have would be to include the following sentence with no visible example:

Dropdown menus can also be triggered above elements, refer to <a href="components/#btn-dropdowns-dropup">Button group dropup variation</a> for more information and examples.

What is your preference?

@mdo
Copy link
Member

mdo commented Feb 10, 2015

A live example to go with it is probably preferable, so we can go with that.

Condense the dropup example
@kkirsche
Copy link
Contributor Author

Changed to the first option which uses short sentence with a live example in the first example box.

@cvrebert
Copy link
Collaborator

@mdo LGTY?

@mdo
Copy link
Member

mdo commented Feb 19, 2015

:shipit:

cvrebert added a commit that referenced this pull request Feb 19, 2015
Fix issue #15597 — Mention dropup variation in dropdown docs
@cvrebert cvrebert merged commit 0b10c6b into twbs:master Feb 19, 2015
@cvrebert cvrebert mentioned this pull request Feb 19, 2015
@kkirsche
Copy link
Contributor Author

Thanks guys! 👍

@kkirsche kkirsche deleted the patch-5 branch February 19, 2015 21:29
daveaglick added a commit to daveaglick/FluentBootstrap that referenced this pull request Apr 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.dropup should be mentioned in main Dropdown docs
4 participants