Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AnchorJS for docs anchors. #15491

Merged
merged 1 commit into from Jan 22, 2015
Merged

Add AnchorJS for docs anchors. #15491

merged 1 commit into from Jan 22, 2015

Conversation

XhmikosR
Copy link
Member

@XhmikosR XhmikosR commented Jan 5, 2015

@cvrebert cvrebert added the docs label Jan 5, 2015
@cvrebert
Copy link
Collaborator

cvrebert commented Jan 5, 2015

https://github.com/bryanbraun/anchorjs#compatibility says it supports IE9+. Does it at least fail somewhat gracefully in IE8?

@XhmikosR
Copy link
Member Author

XhmikosR commented Jan 5, 2015

Nope. I have already opened an issue for that, but didn't have the time to finish the patch.

With IE8, the anchor icon won't show up; the a element will though.

@cvrebert
Copy link
Collaborator

cvrebert commented Jan 5, 2015

That's sufficiently graceful for me.

@XhmikosR
Copy link
Member Author

XhmikosR commented Jan 5, 2015

Agreed. I might find the time to finish the IE8 support upstream, but being that we won't care about it with v4, you know :p

@hnrch02
Copy link
Collaborator

hnrch02 commented Jan 5, 2015

👍

@mdo mdo self-assigned this Jan 6, 2015
@XhmikosR XhmikosR added this to the v3.3.2 milestone Jan 6, 2015
@XhmikosR XhmikosR force-pushed the docs-anchors branch 2 times, most recently from f639b9c to f10b174 Compare January 6, 2015 22:34
@mdo mdo modified the milestones: v3.3.2, v3.3.3 Jan 19, 2015
@mdo mdo merged commit 3f512c9 into master Jan 22, 2015
@mdo mdo deleted the docs-anchors branch January 22, 2015 03:22
@cvrebert cvrebert mentioned this pull request Jan 22, 2015
Closed
@markhalliwell markhalliwell mentioned this pull request Apr 7, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mdo mdo

Labels
docs
Projects
None yet
Milestone
v3.3.4
Development

Successfully merging this pull request may close these issues.

Add permalink on hover in docs headers
4 participants
@XhmikosR @cvrebert @hnrch02 @mdo