Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed proper navigation element selection on backward scrolling (from the bottom to the top) #16043

Merged
merged 1 commit into from Mar 15, 2015
Merged

Fixed proper navigation element selection on backward scrolling (from the bottom to the top) #16043

merged 1 commit into from Mar 15, 2015

Conversation

maximandrews
Copy link
Contributor

Found scrollspy issue.
It was selecting wrong navigation element. Wrong behavior were produced by unnecessary equal sign on line 99 (comparison of target offsets)

@twbs-savage
Copy link

Tests passed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED

Commit: 8337173
Build details: https://travis-ci.org/twbs-savage/bootstrap/builds/53855150

(Please note that this is a fully automated comment.)

@cvrebert cvrebert added the js label Mar 10, 2015
@cvrebert cvrebert added this to the v3.3.4 milestone Mar 10, 2015
@cvrebert
Copy link
Collaborator

I've confirmed that the new unit test correctly fails when the included fix is reverted.

@maximandrews
Copy link
Contributor Author

@cvrebert thanks for immediate response.

@cvrebert
Copy link
Collaborator

MSTM and LGTM. Thanks for including regression/unit tests!
CC: @XhmikosR @hnrch02 @juthilo for further review

@maximandrews
Copy link
Contributor Author

You welcome.

cvrebert added a commit that referenced this pull request Mar 15, 2015
ScrollSpy: Fixed proper nav element selection when scrolling upwards
@cvrebert cvrebert merged commit 43b8fd8 into twbs:master Mar 15, 2015
@cvrebert cvrebert mentioned this pull request Mar 15, 2015
@maximandrews maximandrews deleted the backward-scrolling branch March 15, 2015 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants