Update all collapse triggers with .collapsed class and aria-expanded #15941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $target.click() | ||
| }) | ||
|
|
||
| QUnit.test('should add "collapsed" class to all triggers targeting href of target when collapse is hidden', function (assert) { |
There was a problem hiding this comment.
"targeting href of target" sounds a bit wonky.
There was a problem hiding this comment.
How about just "targeting the collapse"?
There was a problem hiding this comment.
Yeah, that's much clearer.
|
LGTM otherwise. |
cvrebert
force-pushed
the
ijcheung-collapse-update-all-triggers
branch
from
ecf3392
to
d5071b1
Compare
cvrebert
added a commit
that referenced
this pull request
Feb 27, 2015
…gers Update all collapse triggers with .collapsed class and aria-expanded
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15741.
Closes #15751 by merging it.
CC: @hnrch02 for final re-review