Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed performance bug where a tooltip element is unnecessarily created #15557

Conversation

Que3216
Copy link
Contributor

@Que3216 Que3216 commented Jan 13, 2015

Fixed performance bug where a tooltip element is created and then immediately destroyed when tooltip.hide() is called and there is no existing tooltip element

…ediately destroyed when tooltip.hide() is called and there is no existing tooltip element
@twbs-savage
Copy link

Tests passed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED

Commit: f4ac466
Build details: https://travis-ci.org/twbs-savage/bootstrap/builds/46860693

(Please note that this is a fully automated comment.)

@cvrebert cvrebert added the js label Jan 13, 2015
@cvrebert cvrebert added this to the v3.3.4 milestone Feb 26, 2015
@cvrebert
Copy link
Collaborator

Seems reasonable to me. @hnrch02 @XhmikosR What do you guys think?

@cvrebert cvrebert mentioned this pull request Feb 26, 2015
@hnrch02 hnrch02 closed this in acc5f65 Feb 26, 2015
@XhmikosR
Copy link
Member

👍 definitely makes sense

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants