Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip .disabled instead of .divider on dropdown keydown event #15520

Closed
wants to merge 1 commit into from
Closed

Skip .disabled instead of .divider on dropdown keydown event #15520

wants to merge 1 commit into from

Conversation

vsn4ik
Copy link
Contributor

@vsn4ik vsn4ik commented Jan 8, 2015

Thanks @ankurkaushal.

Fix #15147.
Closes #15281.

@twbs-savage
Copy link

Tests passed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED

Commit: 239ab85
Build details: https://travis-ci.org/twbs-savage/bootstrap/builds/46293079

(Please note that this is a fully automated comment.)

@cvrebert cvrebert added the js label Jan 8, 2015
@cvrebert
Copy link
Collaborator

Isn't this just a duplicate of #15281?

@vsn4ik
Copy link
Contributor Author

vsn4ik commented Feb 26, 2015

No. I wrote a cleaner unit case.

@hnrch02 hnrch02 added this to the v3.3.4 milestone Feb 26, 2015
@hnrch02 hnrch02 mentioned this pull request Feb 26, 2015
Closed
@cvrebert cvrebert mentioned this pull request Feb 26, 2015
Closed
@hnrch02 hnrch02 closed this in b395f35 Feb 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
js
Projects
None yet
Milestone
v3.3.4
Development

Successfully merging this pull request may close these issues.

Dropdown: Change .divider to .disabled on keydown event.
4 participants
@vsn4ik @twbs-savage @cvrebert @hnrch02