Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make $(document).tooltip({...}) without a selector throw an error #15496

Merged
merged 2 commits into from Jan 28, 2015
Merged

Make $(document).tooltip({...}) without a selector throw an error #15496

merged 2 commits into from Jan 28, 2015

Conversation

cvrebert
Copy link
Collaborator

@cvrebert cvrebert commented Jan 5, 2015

Alternative fix for #15484.
Makes $(document).tooltip({...}) without specifying a selector option throw an explicit error, since not specifying a selector for delegation in this case is absurd.

@cvrebert cvrebert added the js label Jan 5, 2015
@cvrebert cvrebert added this to the v3.3.2 milestone Jan 5, 2015
@cvrebert
Copy link
Collaborator Author

cvrebert commented Jan 5, 2015

CC: @Darkseal @fat

@cvrebert
Copy link
Collaborator Author

cvrebert commented Jan 5, 2015

Hmm, failing on IE8. I'll investigate.

@cvrebert
Copy link
Collaborator Author

cvrebert commented Jan 5, 2015

Works on IE8 now.

@cvrebert cvrebert mentioned this pull request Jan 6, 2015
Closed
@cvrebert
Copy link
Collaborator Author

CC: @XhmikosR @hnrch02 for review since fat is AFK

@mdo mdo modified the milestones: v3.3.2, v3.3.3 Jan 19, 2015
@XhmikosR
Copy link
Member

Looks good as far as I can tell. 👍

@cvrebert
Copy link
Collaborator Author

@hnrch02 LGTY?

@hnrch02
Copy link
Collaborator

hnrch02 commented Jan 28, 2015

👍

cvrebert added a commit that referenced this pull request Jan 28, 2015
@cvrebert
Merge pull request #15496 from twbs/15484-alternative
cd4467b 
Make $(document).tooltip({...}) without a `selector` throw an error
@cvrebert cvrebert merged commit cd4467b into master Jan 28, 2015
@cvrebert cvrebert deleted the 15484-alternative branch January 28, 2015 19:05
@cvrebert cvrebert mentioned this pull request Jan 28, 2015
Closed
cvrebert added a commit that referenced this pull request Mar 3, 2015
@cvrebert
rm semicolon for sake of fat's eccentric tastes
168297c 
Erratum from #15496
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
js
Projects
None yet
Milestone
v3.3.4
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@cvrebert @XhmikosR @hnrch02 @Darkseal @mdo