Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed visibility: hidden !important from .hidden class #15755

Merged
merged 1 commit into from Mar 9, 2015

Conversation

jitendravyas
Copy link

This .hidden was taken from HTML 5 Boilerplate and yesterday we discussed on twitter that visibility: hidden !important can be removed now. https://twitter.com/jitendravyas/status/562940090553733121

  This .hidden was taken from HTML 5 Boilerplate and yesterday we discussed on twitter that visibility: hidden !important can be removed now. https://twitter.com/jitendravyas/status/562940090553733121
@patrickhlauke
Copy link
Member

Purely from my testing (original reason for inclusion of visibility:hidden appears to be weird behavior in old versions of assistive technologies like Window-Eyes that didn't completely remove display:none items from the exposed DOM/accessibility tree), this seem good to me nowadays (from basic testing and experience, display:none on its own behaves correctly in all major screenreader/browser combinations, to my knowledge). /cc @stevefaulkner

@stevefaulkner
Copy link

(from basic testing and experience, display:none on its own behaves correctly in all major screenreader/browser combinations

agreed.
Somewhat related, you don't need to use aria-hidden=true in combo with display:none :-)

@patrickhlauke
Copy link
Member

@stevefaulkner

Somewhat related, you don't need to use aria-hidden=true in combo with display:none

are there instances where we do this in bootstrap (honest question, lost track of whether we do or not)?

@stevefaulkner
Copy link

@patrickhlauke

are there instances where we do this in bootstrap (honest question, lost track of whether we do or not)?

Not that I have seen, but it's out there as advice, due to recommendation in ARIA 1.0, since removed in ARIA 1.1 as it is unnecessary

@cvrebert cvrebert added this to the v3.3.4 milestone Feb 7, 2015
@mdo
Copy link
Member

mdo commented Feb 9, 2015

So we can drop this entirely now? I think we just added it in v3.3.2 lol.

@mdo
Copy link
Member

mdo commented Feb 9, 2015

If so, we'll need to remove all our other instances (collapse plugin, etc).

@patrickhlauke
Copy link
Member

So we can drop this entirely now?

I believe so, yes.

@cvrebert
Copy link
Collaborator

cvrebert commented Mar 9, 2015

X-Ref: h5bp/html5-boilerplate#1663

@cvrebert
Copy link
Collaborator

cvrebert commented Mar 9, 2015

Merging this for now so that we match h5bp. Let's punt the aria-hidden redundancy to a new issue.

cvrebert added a commit that referenced this pull request Mar 9, 2015
Removed `visibility: hidden !important` from `.hidden` class
@cvrebert cvrebert merged commit 38fbd8f into twbs:master Mar 9, 2015
cvrebert added a commit that referenced this pull request Mar 9, 2015
@cvrebert
Copy link
Collaborator

cvrebert commented Mar 9, 2015

Opened #16020 and #16021 as follow-ups.

@cvrebert cvrebert mentioned this pull request Mar 9, 2015
cvrebert added a commit that referenced this pull request Apr 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants