Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract responsive embed nested classes #15726

Merged
merged 1 commit into from Feb 3, 2015
Merged

Extract responsive embed nested classes #15726

merged 1 commit into from Feb 3, 2015

Conversation

hkdobrev
Copy link
Contributor

@hkdobrev hkdobrev commented Feb 2, 2015

I think this is the more common coding convention across Bootstrap.

Extract nested classes as first-class citizens and assume HTML would use both.

I think this is the more common coding convention across Bootstrap.

Extract nested classes as first-class citizens and assume HTML would use both.
@cvrebert cvrebert added the css label Feb 2, 2015
@cvrebert
Copy link
Collaborator

cvrebert commented Feb 2, 2015

👍

@mdo mdo added this to the v3.3.4 milestone Feb 3, 2015
@mdo
Copy link
Member

mdo commented Feb 3, 2015

LGTM.

cvrebert added a commit that referenced this pull request Feb 3, 2015
Extract responsive embed nested classes
@cvrebert cvrebert merged commit 54bae8f into twbs:master Feb 3, 2015
@cvrebert cvrebert mentioned this pull request Feb 3, 2015
@hkdobrev hkdobrev deleted the fix-embed-responsive-code branch February 3, 2015 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants