Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix Issue #15719] Add a variable for .form-group's margin-bottom #15728

Merged
merged 2 commits into from Feb 9, 2015

Conversation

kkirsche
Copy link
Contributor

@kkirsche kkirsche commented Feb 2, 2015

[Fix Issue #15719] Add a variable for .form-group's margin-bottom

@mdo mdo added this to the v3.3.4 milestone Feb 3, 2015
@mdo
Copy link
Member

mdo commented Feb 3, 2015

I'm good with this.

@cvrebert
Copy link
Collaborator

cvrebert commented Feb 3, 2015

SemVer requires that this would be for v3.4.0 rather than the next patch release.

@mdo
Copy link
Member

mdo commented Feb 3, 2015

Really? For a variable change? If so, let's punt on it, but I know we've added variables for things previously without bumping a minor version.

@cvrebert
Copy link
Collaborator

cvrebert commented Feb 3, 2015

Guess it's a matter of how strict we wanna be. I'm very much in favor of adding the var over not adding it.

@mdo mdo removed the feature label Feb 9, 2015
mdo added a commit that referenced this pull request Feb 9, 2015
[Fix Issue #15719] Add a variable for .form-group's margin-bottom
@mdo mdo merged commit 8ef21c7 into twbs:master Feb 9, 2015
@kkirsche kkirsche deleted the patch-11 branch June 16, 2015 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants