Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a variable for .form-group's margin-bottom #15719

Closed
mryellow opened this issue Feb 1, 2015 · 7 comments
Closed

Add a variable for .form-group's margin-bottom #15719

mryellow opened this issue Feb 1, 2015 · 7 comments
Labels
css feature
Milestone
v3.3.4

Comments

@mryellow
Copy link

mryellow commented Feb 1, 2015

#3737

@mdo The forms can be customized easily enough to reduce this when folks need it.

This statement is inaccurate, form control .form-group margin is not exposed in the LESS.

.form-group {
     margin-bottom: 15px
}
@cvrebert cvrebert added the css label Feb 1, 2015
@cvrebert
Copy link
Collaborator

cvrebert commented Feb 1, 2015

@mryellow The CSS you refer to no longer exists in Bootstrap v3. We don't set margin-bottom: 15px on .form-control anywhere.

@mryellow
Copy link
Author

mryellow commented Feb 2, 2015

It's in the current master and 3.3.2

bootstrap/less/forms.less

Line 200 in 85a6595

.form-group {

https://github.com/twbs/bootstrap/blob/v3.3.2/less/forms.less#L200

@cvrebert
Copy link
Collaborator

cvrebert commented Feb 2, 2015

Your original post says .form-control, not .form-group.

@cvrebert cvrebert changed the title Form margin not exposed in LESS Add a variable for .form-group's margin-bottom Feb 2, 2015
@mryellow
Copy link
Author

mryellow commented Feb 2, 2015

Ahh too right, thanks. I had mistakenly worked around it by overloading form-control instead of form-group.

@kkirsche
Copy link
Contributor

kkirsche commented Feb 2, 2015

@cvrebert I can easily add a variable for this to variables LESS file, will it also require being exposed in the customizer or is it automatically loaded?

@cvrebert
Copy link
Collaborator

cvrebert commented Feb 2, 2015

@kkirsche That's done automatically via the customizer-related Jade Grunt tasks.

kkirsche added a commit to kkirsche/bootstrap that referenced this issue Feb 2, 2015
@kkirsche
[Fix issue twbs#15719] Add a variable for .form-group's margin-bottom
99fc85e 
[Fix issue twbs#15719] Add a variable for .form-group's margin-bottom
@kkirsche kkirsche mentioned this issue Feb 2, 2015
Merged
@cvrebert cvrebert mentioned this issue Feb 9, 2015
Closed
mdo added a commit that referenced this issue Feb 9, 2015
@mdo
Merge pull request #15728 from kkirsche/patch-11
8ef21c7 
[Fix Issue #15719] Add a variable for .form-group's margin-bottom
@cvrebert cvrebert added this to the v3.3.4 milestone Feb 10, 2015
@cvrebert
Copy link
Collaborator

Fixed by #15728.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
css feature
Projects
None yet
Milestone
v3.3.4
Development

No branches or pull requests
3 participants
@mryellow @cvrebert @kkirsche