Fix #15652 — Ensure inline checkboxes and radio buttons are relatively positioned #15656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkirsche
changed the title
| @@ -244,6 +244,7 @@ input[type="search"] { | |||
| vertical-align: middle; | |||
| font-weight: normal; | |||
| cursor: pointer; | |||
| position: relative; | |||
There was a problem hiding this comment.
position should come first in the property order.
|
I'll get that fixed tonight when I get home or tomorrow morning. Anything else? |
|
@kkirsche Nope, that's it :). |
Fixes issue twbs#15652 by setting position: relative; to .radio-inline and .checkbox-inline Fix location of position in prop order
|
Rebased and pushed with that change. |
|
Wanted to follow up about this and just check if anything else was necessary. Thanks for your time guys 👍 |
|
|
|
@kkirsche Can you rebase it once more to fix the commit message? |
cvrebert
changed the title
Closed
|
I can now. Sorry, just got home @cvrebert |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15652. Sets position: relative; to .radio-inline and .checkbox-inline. While not technically an "issue" with bootstrap, @mdo had mentioned in the comments of the issue that he didn't mind adding this to the repo.