Cannot subclass HttpHeaders and build with JDK 7 with maven build of 4.0.26.Final #3548
Comments
|
@timboudreau - Thanks for reporting! @normanmaurer - Building the releases from jdk7 sounds reasonable...WDYT? |
|
Sounds good to me. See the |
trustin
added a commit
that referenced
this issue
Mar 29, 2015
Motivations: JDK 1.8 adds default methods to collections classes that reference classes that don't exist in JDK 7. That's binary compatible, but not source compatible. Modifications: Enforce JDK version to be 1.7.* when releasing Result: Fixes #3548
trustin
added a commit
that referenced
this issue
Mar 29, 2015
Motivations: JDK 1.8 adds default methods to collections classes that reference classes that don't exist in JDK 7. That's binary compatible, but not source compatible. Modifications: Enforce JDK version to be 1.7.* when releasing Result: Fixes #3548
|
@timboudreau @trustin I will revert this one as it seems like it was fixed in java some time ago |
normanmaurer
added a commit
that referenced
this issue
Dec 9, 2016
Motivation: We previously changed netty to always compile with java7 as otherwise source compatibility was broken. This was reported in [#3548] but was fixed in the meantime: - https://bugs.openjdk.java.net/browse/JDK-8029240 - https://bugs.openjdk.java.net/browse/JDK-8030855 Modifications: Use again java8 and so remove all the reflection hacks. Result: Easier to maintain code.
normanmaurer
added a commit
that referenced
this issue
Dec 13, 2016
Motivation: We previously changed netty to always compile with java7 as otherwise source compatibility was broken. This was reported in [#3548] but was fixed in the meantime: - https://bugs.openjdk.java.net/browse/JDK-8029240 - https://bugs.openjdk.java.net/browse/JDK-8030855 Modifications: Use again java8 and so remove all the reflection hacks. Result: Easier to maintain code.
normanmaurer
added a commit
that referenced
this issue
Dec 14, 2016
Motivation: We previously changed netty to always compile with java7 as otherwise source compatibility was broken. This was reported in [#3548] but was fixed in the meantime: - https://bugs.openjdk.java.net/browse/JDK-8029240 - https://bugs.openjdk.java.net/browse/JDK-8030855 Modifications: Change minimum JDK version for compilation to 1.8 Result: Easier to maintain code.
normanmaurer
added a commit
that referenced
this issue
Dec 20, 2016
Motivation: We previously changed netty to always compile with java7 as otherwise source compatibility was broken. This was reported in [#3548] but was fixed in the meantime: - https://bugs.openjdk.java.net/browse/JDK-8029240 - https://bugs.openjdk.java.net/browse/JDK-8030855 Modifications: Change minimum JDK version for compilation to 1.8 Result: Easier to maintain code.
normanmaurer
added a commit
that referenced
this issue
Feb 10, 2017
Motivation: We previously changed netty to always compile with java7 as otherwise source compatibility was broken. This was reported in [#3548] but was fixed in the meantime: - https://bugs.openjdk.java.net/browse/JDK-8029240 - https://bugs.openjdk.java.net/browse/JDK-8030855 Modifications: Change minimum JDK version for compilation to 1.8 Result: Easier to maintain code.
normanmaurer
added a commit
that referenced
this issue
Feb 14, 2017
Motivation: We previously changed netty to always compile with java7 as otherwise source compatibility was broken. This was reported in [#3548] but was fixed in the meantime: - https://bugs.openjdk.java.net/browse/JDK-8029240 - https://bugs.openjdk.java.net/browse/JDK-8030855 Modifications: Change minimum JDK version for compilation to 1.8 Result: Easier to maintain code.
normanmaurer
added a commit
that referenced
this issue
Feb 14, 2017
Motivation: We previously changed netty to always compile with java7 as otherwise source compatibility was broken. This was reported in [#3548] but was fixed in the meantime: - https://bugs.openjdk.java.net/browse/JDK-8029240 - https://bugs.openjdk.java.net/browse/JDK-8030855 Modifications: Change minimum JDK version for compilation to 1.8 Result: Easier to maintain code.
liuzhengyang
pushed a commit
to liuzhengyang/netty
that referenced
this issue
Sep 10, 2017
Motivation: We previously changed netty to always compile with java7 as otherwise source compatibility was broken. This was reported in [netty#3548] but was fixed in the meantime: - https://bugs.openjdk.java.net/browse/JDK-8029240 - https://bugs.openjdk.java.net/browse/JDK-8030855 Modifications: Change minimum JDK version for compilation to 1.8 Result: Easier to maintain code.
kiril-me
pushed a commit
to kiril-me/netty
that referenced
this issue
Feb 28, 2018
Motivation: We previously changed netty to always compile with java7 as otherwise source compatibility was broken. This was reported in [netty#3548] but was fixed in the meantime: - https://bugs.openjdk.java.net/browse/JDK-8029240 - https://bugs.openjdk.java.net/browse/JDK-8030855 Modifications: Change minimum JDK version for compilation to 1.8 Result: Easier to maintain code.
pulllock
pushed a commit
to pulllock/netty
that referenced
this issue
Oct 19, 2023
Motivations: JDK 1.8 adds default methods to collections classes that reference classes that don't exist in JDK 7. That's binary compatible, but not source compatible. Modifications: Enforce JDK version to be 1.7.* when releasing Result: Fixes netty#3548
pulllock
pushed a commit
to pulllock/netty
that referenced
this issue
Oct 19, 2023
Motivation: We previously changed netty to always compile with java7 as otherwise source compatibility was broken. This was reported in [netty#3548] but was fixed in the meantime: - https://bugs.openjdk.java.net/browse/JDK-8029240 - https://bugs.openjdk.java.net/browse/JDK-8030855 Modifications: Change minimum JDK version for compilation to 1.8 Result: Easier to maintain code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It seems the build of Netty 4.0.26.Final from Maven is built with JDK 8, which adds default methods to collections classes that reference classes that don't exist in JDK 7. That's binary compatible, but not source compatible, as follows:
I am stuck with JDK 7 for a while longer (thanks @schue ) for Actuer. As of Netty 4.0.26.Final my build is broken because javac sees
spliteratormethods and classes inHttpHeaders. To fix it I'm staying with Netty 4.0.25 for now for Acteur, but that's not a long-term solution.Since AFAIK, Netty 4 is buildable on JDK 7, is it possible for JARs released to Maven Central also to be built with JDK 7?
I imagine I am not the only one in this situation.
The text was updated successfully, but these errors were encountered: