bug: rc0 Header icons/buttons on left of header bar can't get "activated" class due to swipe to go back change #3348
Comments
djett41
changed the title
|
Can you put a codepen together or where you are seeing this? |
|
@mhartington you can replicate it on the ionic codepen /demo for ion-list at http://ionicframework.com/docs/api/directive/ionList/ by clicking on the delete header icon on the left. |
|
Devin http://medgorodok.org.ua/opcion_rejting 19.03.2015, 20:10, "Devin Jett" notifications@github.com: you can replicate it on the ionic codepen /demo for ion-list at by clicking on the delete header icon on the left. —Reply to this email directly or . |
|
should be fixed via 36df508 |
|
@mhartington @perrygovier Thanks for getting to this quick! I'm curious, what would be the side effect of removing the hitX check completely? While bumping down the check to 30 from 45 looks alot better, any clicks to the left of the icon under 30 still dont get activated of course, which can give off the impression that the click didn't go through. I have even unconsciously double clicked real fast, thinking that i missed the icon. Since my app uses nested states, I can't really use the swipe to go back feature anyway unless I change my templates all around which is not on my priority list, so I'm debating forking the repo and removing this code to give users a better experience. I would just like to understand what else this may break. |
|
@adamdbradley would be able to better explain this. |
|
@adamdbradley Could you please explain the need for this? Still all buttons within 30px of the left side of the screen don't get activated. |
|
I am having this exact same issue!!! showLogOutMenu() never gets called...
<h2 id="menu-heading8" style="color:#FFFFFF;font-weight:600;text-align:center;" class=" " data-componentid="heading8">User Name</h2> <i class="icon ion-image" style="font-size: 64px; color: rgb(136, 136, 136); vertical-align: middle;"></i>
|
|
About 36df508: how is decreasing that value supposed to make the side menu any more responsive to my missed inputs (other than putting it to zero / removing it)? I am just getting under the hood of this framework: is there another location in the code that handles inputs for x < 30? |
|
@mhartington unfortunately, it was not fixed by 36df508. |
|
@mhartington Please reopen this issue, we still has the same exact issue. |
|
This issue was moved to ionic-team/ionic-v1#200 |
|
Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out. |
Type: bug
Platform: all
When clicking on a button or icon to the left of the screen (x coordinate 45 and under), the activated class never gets added.
In the activator.js file, there is code that will return if the x coordinate is 45 or under. (8ebde73)
I'm sure theres a reason for this code being added as part of the swipe to go back feature, however this does not give a great UX when clicking buttons/icons on the left side of the screen, especially in the header bar, or in modals
An example of this is in the ionic list demo (http://ionicframework.com/docs/api/directive/ionList/ ). The delete circle in the header will not get "activated" unless you click outside of the circle to the right.
The text was updated successfully, but these errors were encountered: