Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: ion-content has 1px padding-bottom in tab view #2910

Closed
jasperkuperus opened this issue Jan 10, 2015 · 1 comment
Closed

bug: ion-content has 1px padding-bottom in tab view #2910

jasperkuperus opened this issue Jan 10, 2015 · 1 comment

Comments

@jasperkuperus
Copy link

Type: bug
Platform: all
JSFiddle: http://jsfiddle.net/jasperkuperus/yk62zsxv/1/

If you work with a tab view, the ion-content seems to have 1px padding too much on the bottom. Scroll all the way down in my JSFiddle and you will see 1 pixel line that is red (which is ion-content). The screenshot below also shows it:

screen shot 2015-01-10 at 17 31 44

I hunted this issue down to two lines of code in _scaffolding.scss, lines 65-69 in beta 14:

  // Hide the top border if any
  margin-top: -1px;

  // Prevents any distortion of lines
  padding-top:1px;

Removing both of these lines solves my issue. However, the comments suggest there is a very good reason for having these lines in place (which does not show in my specific scenario). This withholds me from simply removing the lines and submitting a pull request. Could someone please elaborate on this?

@gaguirre
Copy link

Same issue. I think the best way to fix it is adding margin-bottom: -1px;
I'll send a pull-request

adamdbradley added a commit that referenced this issue Mar 11, 2015
fix(scrollView): remove bottom margin on scroll content. Closes #2910
@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants