Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: Collection repeat doesn't render list properly #3240

Closed
jryu01 opened this issue Mar 5, 2015 · 6 comments
Closed

bug: Collection repeat doesn't render list properly #3240

jryu01 opened this issue Mar 5, 2015 · 6 comments
Milestone
1.0.0-rc0

Comments

@jryu01
Copy link

jryu01 commented Mar 5, 2015

Type: bug

Platform: all

Collection repeat doesn't render list properly with fixed item-height and item-width property set.

I have two tabs, home and list. list controller initiate an array which is used for collection-repeat from shared angular service. The list is shared between controller via angular service. When I add items to the list from home view(home controller) and then switch tab to list view, list items are not rendered correctly when collection-repeat is used with item-height and item-width property set. When collection-repeat is used without those property, it works fine.

Here is codepen examples:

With item-width and item-height (not working):
http://codepen.io/jryu01/pen/azjgrz

without item-width and item-height (working):
http://codepen.io/jryu01/pen/XJPrRe
@jryu01
Copy link
Author

jryu01 commented Mar 5, 2015

This happens in nightly build.

@ajoslin
Copy link
Contributor

ajoslin commented Mar 6, 2015

You'll notice if you resize the window, it then properly renders.

It's not properly resizing the repeater when reconnecting a cached view. It's too bad we didn't catch this before the rc0 release!

I'll have something pushed to nightly later today to fix this. We'll probably have to re-release for this @adamdbradley.

@perrygovier perrygovier added this to the 1.0.0-rc0 milestone Mar 6, 2015
@ajoslin ajoslin closed this as completed in 4325025 Mar 7, 2015
@ajoslin ajoslin removed the ready label Mar 7, 2015
@ajoslin
Copy link
Contributor

ajoslin commented Mar 7, 2015

Fixed in nightly.

@jryu01
Copy link
Author

jryu01 commented Mar 9, 2015

Now it works with item-width and item-height. But breaks without item-width and height.
If you go friends list tab first, go back to home tab and add friends, It doesn't update the list.
Check this:
http://codepen.io/jryu01/pen/XJPrRe

@jianbo
Copy link

jianbo commented Apr 1, 2015

I get a blank collection-repeat list if I switch tab before the collection-repeat list gets rendered, when I resize they appeared. Is there a resize function that I can call to fix this for now?

@gsanjeevkumar
Copy link

I know its an old bug, but i just realized all my collection-repeats are only showing the first set that to whatever is visible in the window. and when i scroll there is nothing but the background.... no items

can anyone guide me please

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0-rc0
Development

No branches or pull requests
5 participants
@jianbo @perrygovier @gsanjeevkumar @ajoslin @jryu01