Skip to content

Commit

Permalink
SI-9027 Backport xml parser fix
Browse files Browse the repository at this point in the history
Fingers crossed, I have no local java 6 here to test.

No test because no q"" on 2.10.
  • Loading branch information
som-snytt committed Dec 4, 2014
1 parent a908ded commit 736293a
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 6 deletions.
6 changes: 6 additions & 0 deletions bincompat-backward.whitelist.conf
Expand Up @@ -100,6 +100,12 @@ filter {
{
matchName="scala.reflect.runtime.SymbolLoaders.isInvalidClassName"
problemName=MissingMethodProblem
},

{
matchName="scala.xml.dtd.ElementValidator.scala$xml$dtd$ElementValidator$$find$2"
problemName=IncompatibleMethTypeProblem
}
]
}

5 changes: 5 additions & 0 deletions bincompat-forward.whitelist.conf
Expand Up @@ -182,6 +182,11 @@ filter {
# only accessible from util.parsing.combinator package
matchName="scala.util.parsing.combinator.SubSequence"
problemName=MissingClassProblem
},

{
matchName="scala.xml.dtd.ElementValidator.scala$xml$dtd$ElementValidator$$find$2"
problemName=IncompatibleMethTypeProblem
}
]
}
11 changes: 5 additions & 6 deletions src/compiler/scala/tools/nsc/ast/parser/MarkupParsers.scala
Expand Up @@ -349,13 +349,12 @@ trait MarkupParsers {
content_LT(ts)

// parse more XML ?
if (charComingAfter(xSpaceOpt) == '<') {
xSpaceOpt
while (ch == '<') {
nextch
if (charComingAfter(xSpaceOpt()) == '<') {
do {
xSpaceOpt()
nextch()
ts append element
xSpaceOpt
}
} while (charComingAfter(xSpaceOpt()) == '<')
handle.makeXMLseq(r2p(start, start, curOffset), ts)
}
else {
Expand Down

1 comment on commit 736293a

@scala-jenkins
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Job pr-scala failed for 736293a Took 72 min. (ping @som-snytt) (results):


To retry exactly this commit, comment PLS REBUILD/pr-scala@736293ab0977a79175ed025149263456526dc561 on PR 4186.
NOTE: New commits are rebuilt automatically as they appear. A forced rebuild is only necessary for transient failures.

Please sign in to comment.