Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Approx. documents should round more aggressively #3722

Closed
danielmewes opened this issue Feb 3, 2015 · 6 comments
Closed

Approx. documents should round more aggressively #3722

danielmewes opened this issue Feb 3, 2015 · 6 comments
Milestone

Comments

@danielmewes
Copy link
Member

I'm currently seeing "About 9080708" on a table in the web UI, which is not only difficult to read but also looks like a very precise number which it is not.
I think "About 9M" would be enough.
I suggest we make it round to the nearest power of thousand, that is 1-3 significant digits.

@danielmewes danielmewes added this to the 2.0-polish milestone Feb 3, 2015
@mglukhovsky
Copy link
Member

Rounding should work -- is this a regression?

@danielmewes
Copy link
Member Author

I'm not sure. I thought we were still rounding. It might just be a setting to make it round earlier.

@deontologician
Copy link
Contributor

We currently have nothing in the template or the view doing any kind of
rounding. I don't see any helpers in utils.coffee for rounding, though I'm
sure I've seen the "9M" behavior before. Will have to investigate in git to
see what it used to do

On Tue, Feb 3, 2015 at 3:34 PM, Daniel Mewes notifications@github.com
wrote:

I'm not sure. I thought we were still rounding. It might just be a setting
to make it round earlier.


Reply to this email directly or view it on GitHub
#3722 (comment)
.

@deontologician
Copy link
Contributor

OK, yeah, on
https://github.com/rethinkdb/rethinkdb/blob/v1.15.3-1/admin/static/coffee/namespaces/namespace.coffee#L186
you can see we used to round the value in the model directly. I'll add that
back in

On Tue, Feb 3, 2015 at 3:37 PM, Josh Kuhn josh@rethinkdb.com wrote:

We currently have nothing in the template or the view doing any kind of
rounding. I don't see any helpers in utils.coffee for rounding, though I'm
sure I've seen the "9M" behavior before. Will have to investigate in git to
see what it used to do

On Tue, Feb 3, 2015 at 3:34 PM, Daniel Mewes notifications@github.com
wrote:

I'm not sure. I thought we were still rounding. It might just be a
setting to make it round earlier.


Reply to this email directly or view it on GitHub
#3722 (comment)
.

@danielmewes danielmewes modified the milestones: 1.16.x, 2.0-polish, 2.0 Feb 3, 2015
@deontologician
Copy link
Contributor

This is a pretty simple fix, I'll put it on the 1.16.x branch and backport it to next

@deontologician
Copy link
Contributor

Up in CR 2563, branch is josh/3722

@danielmewes danielmewes modified the milestones: 1.16.x, 2.0 Feb 4, 2015
@AtnNn AtnNn modified the milestones: 1.16.x, 1.16.1 Feb 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants