Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash in polyglot/changefeeds/sindex #3765

Closed
Tryneus opened this issue Feb 11, 2015 · 4 comments
Closed

Crash in polyglot/changefeeds/sindex #3765

Tryneus opened this issue Feb 11, 2015 · 4 comments
Assignees
Milestone

Comments

@Tryneus
Copy link
Member

Tryneus commented Feb 11, 2015

In next, this only occurs with -i rb, but that is probably because only the ruby client uses parallel query execution at the moment. This was built with gcc.

Start of the crash:

error: Error in ../src/rdb_protocol/changefeed.cc at line 1484:
error: Guarantee failed: [queued_changes.size() == 0]
error: Backtrace:
error: Wed Feb 11 15:14:40 2015

       1: rethinkdb_backtrace(void**, int) at rethinkdb_backtrace.cc:101
       2: backtrace_t::backtrace_t() at backtrace.cc:203
       3: lazy_backtrace_formatter_t::lazy_backtrace_formatter_t() at backtrace.cc:283
       4: format_backtrace(bool) at backtrace.cc:198
       5: report_fatal_error(char const*, int, char const*, ...) at errors.cc:83
       6: ql::changefeed::limit_sub_t::maybe_start() at changefeed.cc:1484
       7: ql::changefeed::limit_sub_t::init(std::vector<std::pair<std::string, std::pair<ql::datum_t, ql::datum_t> >, std::allocator<std::pair<std::string, std::pair<ql::datum_t, ql::datum_t> > > > const&) at changefeed.cc:1606
       8: ql::changefeed::msg_visitor_t::operator()(ql::changefeed::msg_t::limit_start_t const&) const::{lambda(ql::changefeed::limit_sub_t*)#1}::operator()(ql::changefeed::limit_sub_t*) const at changefeed.cc:1752
       9: std::_Function_handler<void (ql::changefeed::limit_sub_t*), ql::changefeed::msg_visitor_t::operator()(ql::changefeed::msg_t::limit_start_t const&) const::{lambda(ql::changefeed::limit_sub_t*)#1}>::_M_invoke(std::_Any_data const&, ql::changefeed::limit_sub_t*) at functional:1780
       10: std::function<void (ql::changefeed::limit_sub_t*)>::operator()(ql::changefeed::limit_sub_t*) const at functional:2162
@Tryneus Tryneus added this to the 2.0 milestone Feb 11, 2015
@mlucy mlucy modified the milestones: 1.16.x, 2.0 Feb 12, 2015
@mlucy
Copy link
Member

mlucy commented Feb 13, 2015

This is in next and 1.16.x.

@mlucy mlucy closed this as completed Feb 13, 2015
@mlucy
Copy link
Member

mlucy commented Feb 13, 2015

@AtnNn -- could we do a point release for this? It's a pretty bad bug.

@AtnNn
Copy link
Member

AtnNn commented Feb 13, 2015

@mlucy: Yes. What was the bug? Does the crash happen without parallel query execution? I'm mostly curious, and I also want to explain it in the change log.

@mlucy
Copy link
Member

mlucy commented Feb 13, 2015

.orderby.limit.changes was basically just incorrect, there's a race condition where we crash. For whatever reason parallel query execution exposed it.

@AtnNn AtnNn modified the milestones: 1.16.x, 1.16.2 Feb 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants