Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option for hiding "Sign Up" when register is disabled #884

Closed
NewbieOrange opened this issue Jan 31, 2015 · 13 comments
Closed

Add option for hiding "Sign Up" when register is disabled #884

NewbieOrange opened this issue Jan 31, 2015 · 13 comments
Labels
🔨 enhancement Make it better, faster status: needs feedback Tell me more about it

Comments

@NewbieOrange
Copy link

No description provided.

@unknwon
Copy link
Member

unknwon commented Jan 31, 2015

Hi, thanks your feedback!

But don't two buttons are showing at the same time? If changed "sign up" to "sign in", will we have two sign in buttons?

@NewbieOrange
Copy link
Author

Well, if there will be two buttons, remove one. Like there will be only "sign in" in the top right corner.

@unknwon
Copy link
Member

unknwon commented Jan 31, 2015

It's easy to remove one, but would that confuse users without a notice page like current approve?

@NewbieOrange
Copy link
Author

No I think, maybe add a option?

@unknwon unknwon changed the title Change "Sign Up" to "Sign In" when register is disabled Add option for hiding "Sign In" when register is disabled Jan 31, 2015
@unknwon unknwon added the 🔨 enhancement Make it better, faster label Jan 31, 2015
@unknwon
Copy link
Member

unknwon commented Jan 31, 2015

Cool, no problem.

@NewbieOrange NewbieOrange changed the title Add option for hiding "Sign In" when register is disabled Add option for hiding "Sign Up" when register is disabled Jan 31, 2015
@wanghm
Copy link

wanghm commented Feb 2, 2015

We need this feature, too.

@sigwinch28
Copy link

I thought it seemed strange to have the "Sign Up" button around when registration is disabled, too

+1

@nicolai86 nicolai86 mentioned this issue Feb 5, 2015
Merged
unknwon added a commit that referenced this issue Feb 7, 2015
@unknwon
Merge pull request #908 from nicolai86/feature/hide-signup-button-884
87b9037 
Make Signup button display configurable - #884
@unknwon unknwon added the status: needs feedback Tell me more about it label Feb 7, 2015
unknwon added a commit that referenced this issue Feb 7, 2015
@unknwon
code fix for #908, and work for #884
2166830
@unknwon
Copy link
Member

unknwon commented Feb 7, 2015

Hi all, I've pushed a fix related to #908 to dev branch, to hide Sign Up button by default when registration is disable.

@wanghm
Copy link

wanghm commented Feb 12, 2015

Is it possible to hide "Need an account? Sign up now."?

unknwon added a commit that referenced this issue Feb 12, 2015
@unknwon
templates/user/auth/signin.tmpl: hide sign up prompt when registratio…
67a9416 
…n is disabled #884
@unknwon
Copy link
Member

unknwon commented Feb 12, 2015

@wanghm good catch! Fixed pushed to dev.

@unknwon
Copy link
Member

unknwon commented Feb 13, 2015

As new mirror release v0.5.13 is going to release, and this issue is labeled as feedback needed, so close it for assumed resolved, feel free to reopen this if you want to continue discussing. 🍺

@unknwon unknwon closed this as completed Feb 13, 2015
@NewbieOrange
Copy link
Author

Everything works fine, resolved. 😄

@unknwon
Copy link
Member

unknwon commented Feb 14, 2015

@NewbieOrange awesome! 🍺

ethantkoenig added a commit to ethantkoenig/gogs that referenced this issue Feb 11, 2017
@ethantkoenig @lunny
Fix bug in repos search (gogs#884)
2f13d31
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
🔨 enhancement Make it better, faster status: needs feedback Tell me more about it
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sigwinch28 @wanghm @unknwon @NewbieOrange