Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Able to disable SSH feature #883

Closed
NewbieOrange opened this issue Jan 30, 2015 · 9 comments
Closed

Able to disable SSH feature #883

NewbieOrange opened this issue Jan 30, 2015 · 9 comments
Labels
🔨 enhancement Make it better, faster status: needs feedback Tell me more about it

Comments

@NewbieOrange
Copy link

应该加入关闭SSH的设定喔~ 在关闭的时候 不会显示和SSH有关的内容 免得在没开SSH的服务器误导用户

@unknwon unknwon changed the title 增加关闭SSH的设置 Able to disable SSH feature Jan 30, 2015
@unknwon unknwon added the 🔨 enhancement Make it better, faster label Jan 30, 2015
@unknwon
Copy link
Member

unknwon commented Jan 30, 2015

You're right, marked!

unknwon added a commit that referenced this issue Feb 7, 2015
@unknwon
Copy link
Member

unknwon commented Feb 7, 2015

Hi @NewbieOrange , I've pushed code to dev branch.

You are now able to disable SSH by config option [server] DISABLE_SSH = true

@unknwon unknwon added the status: needs feedback Tell me more about it label Feb 7, 2015
@NewbieOrange
Copy link
Author

Seems good, but I am using Windows server... waiting for someone to test it :)

@unknwon
Copy link
Member

unknwon commented Feb 8, 2015

@NewbieOrange , I would say Windows is the type of system need this feature.

You can disable it and web UI should no longer show the SSH-related information.

@NewbieOrange
Copy link
Author

I mean I can't run without a bin file..

@unknwon
Copy link
Member

unknwon commented Feb 9, 2015

@NewbieOrange I see, new mirror release should be very soon!

@unknwon unknwon closed this as completed Feb 13, 2015
@unknwon
Copy link
Member

unknwon commented Feb 13, 2015

As new mirror release v0.5.13 is going to release, and this issue is labeled as feedback needed, so close it for assumed resolved, feel free to reopen this if you want to continue discussing. 🍺

@NewbieOrange
Copy link
Author

最好能让HTTP的地址栏更长一点 或者放在中间 这样看起来正常一点

@unknwon
Copy link
Member

unknwon commented Feb 14, 2015

We want to, but got UI issues, and need to compatible with low resolution screens.

@Loqova
Copy link

Loqova commented May 19, 2022

I have DISABLE_SSH = true but if I check the running processes using docker container top gogs than the process is still running sshd: /usr/sbin/sshd -D -f /app/gogs/docker/sshd_config.

This came to my attention because the Docker Bench for Security v1.3.6 tool mentioned:

[WARN] 5.6 - Ensure sshd is not run within containers (Automated)
[WARN]      * Container running sshd: gogs

Although I did not expose the SSH port, I still assumed that when DISABLE_SSH is used that the SSHD process will not start in the container altogether.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🔨 enhancement Make it better, faster status: needs feedback Tell me more about it
Projects
None yet
Development

No branches or pull requests

3 participants