Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: install-source.html needs updated instructions. #9529

Closed
plan9 opened this issue Jan 7, 2015 · 13 comments
Closed

doc: install-source.html needs updated instructions. #9529

plan9 opened this issue Jan 7, 2015 · 13 comments

Comments

@plan9
Copy link

plan9 commented Jan 7, 2015

as of december 10 "This release also coincides with the project's move from Mercurial to Git"
documentation still referring to mercurial.

@rakyll
Copy link
Contributor

rakyll commented Jan 7, 2015

The doc is not broken.

The latest stable (go1.4) has been released from the Mercurial repo, therefore it's still recommended to install go1.4 from the legacy repo.

@ianlancetaylor
Copy link
Contributor

I agree: I think this is correct. The project moved to git after the 1.4 release, and the 1.4 release is still delivered from Mercurial.

@davecheney
Copy link
Contributor

@ianlancetaylor I believe there is still an issue. Following the install from source instructions gets you Go 1.3, not 1.4

lucky(~) % hg clone -u release https://code.google.com/p/go go1.4                                                                                                                                             
requesting all changes
adding changesets
adding manifests
adding file changes
added 21924 changesets with 76805 changes to 11602 files (+9 heads)
updating to branch release-branch.go1.3
4167 files updated, 0 files merged, 0 files removed, 0 files unresolved

@adg
Copy link
Contributor

adg commented Jan 8, 2015

This will be fixed in 1.4.1. I don't have the patience to figure out why Mercurial is so broken. I'm glad it will all be behind us shortly.

@adg adg closed this as completed Jan 8, 2015
@minux
Copy link
Member

minux commented Jan 8, 2015

Very interesting hg behavior.

I double checked the tags (go1.4 and release) are correct on the
default branch, but

hg clone -u release ...
will get me to release-branch.go1.3 branch, but if I go the
directory, and hg up release again, it will switch to release-branch.go1.4
branch correctly.

@adg
Copy link
Contributor

adg commented Jan 8, 2015

@minux very puzzling indeed. I'm curious as to whether it'll work correctly if you clone -u release from the local repository.

@minux
Copy link
Member

minux commented Jan 8, 2015

If i clone from a local repository (in the default branch, with correct
.hgtags file), things are more interesting (puzzling).

hg clone -u /path/to/go go1.4 # this get me to 1.3 branch
cd go.1.4
hg up release # it stays on 1.3 branch

Only "hg up go1.4" can get me to the 1.4 branch.

and there is no release tag in 1.3 branch's .hgtags, so I don't undertand
why hg insist on 1.3 branch for the release tag.

@adg
Copy link
Contributor

adg commented Jan 8, 2015

As I said, I'm glad this will be behind us soon :-)

@plan9
Copy link
Author

plan9 commented Jan 8, 2015

thank you. I was about to type this up, but thought maybe I'm just nitpicking too much.

... oz
The prepared mind sooner or later
finds something important and does it.
-- richard w. hamming

On Jan 7, 2015, at 8:51 PM, Minux Ma notifications@github.com wrote:

Very interesting hg behavior.

I double checked the tags (go1.4 and release) are correct on the
default branch, but

hg clone -u release ...
will get me to release-branch.go1.3 branch, but if I go the
directory, and hg up release again, it will switch to release-branch.go1.4
branch correctly.

Reply to this email directly or view it on GitHub.

@plan9
Copy link
Author

plan9 commented Jan 8, 2015

thanks @davecheney
since -u release doesn't default to release-branch.go1.4, perhaps this document can at least be updated to clone with -u release-branch.go1.4 directly. i would imagine there is no harm in making it explicit in a legacy repo.

@adg
Copy link
Contributor

adg commented Jan 8, 2015

@plan9
Copy link
Author

plan9 commented Jan 8, 2015

@adg sure that works, avoids mentioning lengthy release names.

@adg
Copy link
Contributor

adg commented Jan 8, 2015

The updated instructions are now rolled out to golang.org.

@mikioh mikioh changed the title doc/install/source broken. doc: install-source.html needs updated instructions. Jan 8, 2015
@golang golang locked and limited conversation to collaborators Jun 25, 2016
@rsc rsc unassigned adg Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants