New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proxy in 0.14.5 is broken #104
Comments
To confirm, yes putting A pull request seems a little overkill for this one-line patch :-) |
Hi @Deathspike, Thanks for catching this issue so quickly! I've published a patch to help you out. However, could you provide me with a real-world example that I can use to test the issue? Currently, we don't have a test case to catch this scenario and I'm unsure how to structure it. Published Thanks! |
Sure! There are many sites that require a valid host header to route into the correct application, and won't work while approached with an incorrect host header or by IP. IIS, Apache and nginx tend to route this way by default. For example, the ASP.NET site runs on http://www.asp.net/ and the equivalent IP at the moment is 168.62.43.5. Go to http://168.62.43.5/ and it won't show the site. Request with an incorrect header, or missing header, and you get a different site too. Here is the same thing as a proxy script:
Note that when the |
This is resolved. I am closing it. |
The proxy middleware has broken down going from 0.14.4 to 0.14.5. It seems like the
host
header is not set correctly. You can test this on any site that serves sites depending on thehost
header (e.g. almost every site on a shared host).Probably because
delete req.headers.host;
was dropped as well in that patch?The text was updated successfully, but these errors were encountered: